RSS/Atom feed Twitter
Site is read-only, email is disabled

animation-play

This discussion is connected to the gimp-developer-list.gnome.org mailing list which is provided by the GIMP developers and not related to gimpusers.com.

This is a read-only list on gimpusers.com so this discussion thread is read-only, too.

3 of 3 messages available
Toggle history

Please log in to manage your subscriptions.

animation-play Mircea Purdea 16 Nov 16:50
  animation-play Martin Nordholts 16 Nov 21:43
   animation-play Martin Nordholts 16 Nov 22:41
Mircea Purdea
2009-11-16 16:50:48 UTC (about 15 years ago)

animation-play

Hello everyone,

I'm new to the list (and to GIMP development) so you'll have to excuse my general noob-ness. I've been using the GIMP for a few years now, and one of the features I often use is the Animation-Playback plugin. Now, I know about GAP (and I use that, too) but the Playback function is still a staple of GIMP use for me. And with that in mind, I thought that this part of GIMP could really use some love; the TO-DO comments have been there for, what, 10 years now?

Now me, I'm very much a beginner when it comes to C, GTK+ and GIMP internals, so I can't really do all that much at this point. What I found I can do (for myself, even if not for inclusion in the stable tree) is
add a UI element for default frame duration. This is something which for me is very important: I work mostly at 12 FPS, so the implicit 100ms is not good enough for me. To this end, I added another combo box to the animation-playback window, with a set of predefined (standard) framerates. I also changed the listing in the duration adjuster combo from % values to 'x'. To me this seems more intuitive (as I think that many people who see the original % values will initially think that the adjuster is used for zoom, rather than speed).

Here is a screenshot to see what I mean: http://nothing.exhalus.net/misc/animation-play.gif

Source code can be downloaded from: http://nothing.exhalus.net/misc/animation-play.zip

The source file is modified from the 2.7 version in git. Now, being a noob, I have yet to find a way to compile this as a stand-alone plugin. If I use the gimptool, I get "initializer element is not constant" errors in 'ui_manager_new'. The only way I could compile this was by doing a full GIMP build from the git source. And while this works in Linux, I can't use this method on Windows. I was able to compile other plugins on Windows, but I never managed to sort out all dependencies for a full Win32 GIMP build. Could anyone help with this?

Also, what do you guys think (in code and design terms) about these UI additions/changes?

Regards,
Mircea

Martin Nordholts
2009-11-16 21:43:15 UTC (about 15 years ago)

animation-play

Mircea Purdea wrote:

Source code can be downloaded from: http://nothing.exhalus.net/misc/animation-play.zip

Hi Mircea!

Modifications to software is generally distributed as patches, look at [1] for basic instructions on how to generate a patch with git.

The source file is modified from the 2.7 version in git. Now, being a noob, I have yet to find a way to compile this as a stand-alone plugin. If I use the gimptool, I get "initializer element is not constant" errors in 'ui_manager_new'.

Yes, the "plug-in" has dependencies to private API, most of it for internationalization. Should be easy to convert it to a proper plug-in.

Also, what do you guys think (in code and design terms) about these UI additions/changes?

I haven't looked at the, but the UI changes seems sane to me.

Regards, Martin

Martin Nordholts
2009-11-16 22:41:06 UTC (about 15 years ago)

animation-play

Martin Nordholts wrote:

Modifications to software is generally distributed as patches, look at [1] for basic instructions on how to generate a patch with git.

I forgot to add:
[1] http://gimp.org/bugs/howtos/submit-patch.html

/ Martin