On Thu, May 14, 2009 at 03:04:27PM +0200, Maciej Pilichowski wrote:

This would be much faster comparing to showing the grid and checking if the grid matches the lines on the image. I am of course wishing for adding another way to do rotation, not to replace any of the method.

I've always just used the measure tool to tell me what the angle is and rotate by that angle. I'm sure your suggestion would make it faster, but not by much.

Jeff

On Thu, 2009-05-14 at 15:51 +0200, Maciej Pilichowski wrote: [..]

I think it would be much straightforward (less thinking) -- "I want to make the line from here to there horizontal/vertical; end".

Go to tool options, choose "corrective mode" and preview "grid". Now, align the grid with the item in your picture that you want to be horizontal or vertical, and click rotate.

You can change the number of grid lines, or the grid line spacing, and sometimes the grid will happen to line up exactly with the feature in your picture.

Liam

On Thu, May 14, 2009 at 7:43 PM, Liam R E Quin wrote:

Go to tool options, choose "corrective mode" and preview "grid". Now, align the grid with the item in your picture that you want to be horizontal or vertical, and click rotate.

In fact every time you will also need to create a different number of grid lines so that one of them would be as close as possible to a potentially horizontal/vertical feature. Straightening with a line the way Maciej described it would make it much easier.

Alexandre

On 05/14/2009 11:51 AM, Alexandre Prokoudine wrote:

On Thu, May 14, 2009 at 7:43 PM, Liam R E Quin wrote:

Go to tool options, choose "corrective mode" and preview "grid". Now, align the grid with the item in your picture that you want to be horizontal or vertical, and click rotate.

In fact every time you will also need to create a different number of grid lines so that one of them would be as close as possible to a potentially horizontal/vertical feature. Straightening with a line the way Maciej described it would make it much easier.

Alexandre

Alexandre,

We use this Gimp feature on virtually every image we create, sometimes _hundreds_ per day.

Once we originally set the number of lines in the grid, we have felt no need to make a change for months ... thousands of images.

However, I do have to say that the Photoshop 5.5 feature of simply drawing a line with the measure tool and then doing the rotate command is more efficient.

And I do like the suggestion of clicking on the first point and then the second point, rather than having to draw a line as in Photoshop.

I would like to see this feature _added_ to Gimp, while still retaining the grid mechanism also.

My desire would be for:

click (on first point) click (on second point to finish the line) do a keystroke command that can be accomplished with ONE hand to execute the task (I would prefer not to have to hit the Enter key)

That would be most efficient.

Jay

2009/5/14 Maciej Pilichowski :

On Thursday 14 May 2009 15:26:46 Jeffrey Brent McBeth wrote:

I've always just used the measure tool to tell me what the angle is and rotate by that angle.  I'm sure your suggestion would make it faster, but not by much.

I think it would be much straightforward (less thinking) -- "I want to make the line from here to there horizontal/vertical; end".

In comparison -- you have to make the same steps, but additionally you have to select another tool and type in the values you see on the screen.

One rotation per day, ok, but ~100 rotations a day, it is significant boost, because it means ~500 keystrokes less (and less focus, you have to pay attention each time you type the values). So, I think you would be less tired with the tool as I proposed after working with the images.

What if the going into the rotation tool from the measure tool set the default rotation? Then you could do shift-M, drag the line, shift-R, then confirm. Don't know how learnable this would be, though.

Henk

On Thu, May 14, 2009 at 8:00 PM, Jay Smith wrote:

In fact every time you will also need to create a different number of grid lines so that one of them would be as close as possible to a potentially horizontal/vertical feature. Straightening with a line the way Maciej described it would make it much easier.

Alexandre,

We use this Gimp feature on virtually every image we create, sometimes _hundreds_ per day.

Once we originally set the number of lines in the grid, we have felt no need to make a change for months ... thousands of images.

"Your mileage may vary" pretty much covers this :)

And I do like the suggestion of clicking on the first point and then the second point, rather than having to draw a line as in Photoshop.

I would like to see this feature _added_ to Gimp, while still retaining the grid mechanism also.

My desire would be for:

  click (on first point)   click (on second point to finish the line)   do a keystroke command that can be accomplished with ONE hand     to execute the task (I would prefer not to have to hit the Enter     key)

Agreed. However, if you choose something over Enter that would be inconsistent with the rest of tools :)

Alexandre

On Thu, May 14, 2009 at 8:02 PM, Henk Boom wrote:

What if the going into the rotation tool from the measure tool set the default rotation? Then you could do shift-M, drag the line, shift-R, then confirm. Don't know how learnable this would be, though.

It's a horrible trick. You would probably never guess if you weren't told how it works or read about it somewhere.

Alexandre

It's a horrible trick. You would probably never guess if you weren't told how it works or read about it somewhere.

So what? It wouldn't hurt anybody either. It would presumably be trivial to implement and it wouldn't require any new UI.

--tml

Jay Smith wrote:

However, I do have to say that the Photoshop 5.5 feature of simply drawing a line with the measure tool and then doing the rotate command is more efficient.

Using the measure tool for this seems like a UI hack to me. IMO we need a better solution for GIMP, something that is more discoverable.

/ Martin

On 05/14/2009 12:36 PM, Martin Nordholts wrote:

Jay Smith wrote:

However, I do have to say that the Photoshop 5.5 feature of simply drawing a line with the measure tool and then doing the rotate command is more efficient.

Using the measure tool for this seems like a UI hack to me. IMO we need a better solution for GIMP, something that is more discoverable.

/ Martin

Martin,

That is a very good point.

I have to admit that I was using Photoshop for a couple of _years_ and had done perhaps 20,000 rotations before I learned about that method (and I found out from a friend, not from the program's help or manual, though it was probably documented).

In any case, the same concept (preferably with BOTH method possible: draw a line or click start, click end) in a more discoverable way would sure be great.

Jay

On Thu, 2009-05-14 at 19:51 +0400, Alexandre Prokoudine wrote:

On Thu, May 14, 2009 at 7:43 PM, Liam R E Quin wrote:

Go to tool options, choose "corrective mode" and preview "grid". Now, align the grid with the item in your picture that you want to be horizontal or vertical, and click rotate.

In fact every time you will also need to create a different number of grid lines so that one of them would be as close as possible to a potentially horizontal/vertical feature. Straightening with a line the way Maciej described it would make it much easier.

Agreed, just wanted to make sure Maciej knew what we already have.

Actually, paintShopPro lets you draw a line, and PhotoShop lets you rotate to an angled guide, but, except for the difficulty of aligning the grid, which I see as a separate issue, the GIMP approach is vastly superior, because you can check alignment against several parts of the image, both horizontal and vertical. But yes, it needs to be streamlined, you are right.

Liam

Playing with this I found an issue. Please confirm if the following is a windows only issue:

When using the measure tool with Use Info Window checked (does it have any use otherwise?) The info box gets focus, so I can no longer use key shortcuts to get other tools.
-Rob A>

On 5/14/09, Jay Smith wrote:

On 05/14/2009 12:36 PM, Martin Nordholts wrote:

Jay Smith wrote:

However, I do have to say that the Photoshop 5.5 feature of simply drawing a line with the measure tool and then doing the rotate command is more efficient.

Using the measure tool for this seems like a UI hack to me. IMO we need a better solution for GIMP, something that is more discoverable.

/ Martin

Martin,

That is a very good point.

I have to admit that I was using Photoshop for a couple of _years_ and had done perhaps 20,000 rotations before I learned about that method (and I found out from a friend, not from the program's help or manual, though it was probably documented).

In any case, the same concept (preferably with BOTH method possible: draw a line or click start, click end) in a more discoverable way would sure be great.

Jay
_______________________________________________ Gimp-developer mailing list
Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer

Jay Smith writes:

My desire would be for:

click (on first point) click (on second point to finish the line) do a keystroke command that can be accomplished with ONE hand to execute the task (I would prefer not to have to hit the Enter key)

You could perhaps do this with a plug-in:

- Use the Paths tool - Click on first point, then on second point (now you have a straight-line path with two endpoints) - Run a plug-in (which you can assign to any key you like) that gets the current path endpoints, rotates the current layer the appropriate amount, then deletes the path.

It would be an easy plug-in to write. You would stay in the Paths tool and not have to switch tools at all. Would that do what you want?

It would still be a useful feature to add to the Rotate tool, and that discussion should continue; but since any change to a tool won't be available until the next major version, this might be a workaround that you could use right now.

...Akkana

there is such a plugin. I think I saw it in the Meet the Gimp forums.

-Rob A>

On 5/14/09, Akkana Peck wrote:

Jay Smith writes:

My desire would be for:

click (on first point) click (on second point to finish the line) do a keystroke command that can be accomplished with ONE hand to execute the task (I would prefer not to have to hit the Enter key)

You could perhaps do this with a plug-in:

- Use the Paths tool - Click on first point, then on second point (now you have a straight-line path with two endpoints) - Run a plug-in (which you can assign to any key you like) that gets the current path endpoints, rotates the current layer the appropriate amount, then deletes the path.

It would be an easy plug-in to write. You would stay in the Paths tool and not have to switch tools at all. Would that do what you want?

It would still be a useful feature to add to the Rotate tool, and that discussion should continue; but since any change to a tool won't be available until the next major version, this might be a workaround that you could use right now.

...Akkana _______________________________________________ Gimp-developer mailing list
Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer

Quoting Rob Antonishen :

there is such a plugin. I think I saw it in the Meet the Gimp forums.

I wrote the following script a while back for a coin collector who wanted to easily crop his scans and rotate them so that the coin was oriented properly.

The interface I used was to click-drag a path from the top of the coin to the bottom. The resulting path had only one anchor (at the coin's top) but the control handle was used as the second point.

The script would require some modification but might provide a kludgy functionality for those needing it.

http://flashingtwelve.brickfilms.com/GIMP/Scripts/sg-rotate-to-path-points.scm

A discussion over the evolution of the script took place on the GIMPtalk forums:

http://www.gimptalk.com/forum/-script-fu-efficient-rotating-&-cropping-tool-t32052.html-st=0&sk=t&sd=a

saulgoode@flashingtwelve.brickfilms.com wrote:

Quoting Rob Antonishen :

there is such a plugin. I think I saw it in the Meet the Gimp forums.

I wrote the following script a while back for a coin collector who wanted to easily crop his scans and rotate them so that the coin was oriented properly.

The interface I used was to click-drag a path from the top of the coin to the bottom. The resulting path had only one anchor (at the coin's top) but the control handle was used as the second point.

The script would require some modification but might provide a kludgy functionality for those needing it.

http://flashingtwelve.brickfilms.com/GIMP/Scripts/sg-rotate-to-path-points.scm

A discussion over the evolution of the script took place on the GIMPtalk forums:

http://www.gimptalk.com/forum/-script-fu-efficient-rotating-&-cropping-tool-t32052.html-st=0&sk=t&sd=a

Not sure whether its transient or permanent but above URL gives:

SQL ERROR [ mysql4 ] Table './gimptalk_lbsql/phpbb_sessions' is marked as crashed and should be repaired [145]
An sql error occurred while fetching this page. Please contact an administrator if this problem persists.

I found it in Google-cache at: http://tinyurl.com/qsoekx or:

http://www.google.com/url?sa=t&source=web&ct=clnk&cd=1&url=h ttp%3A%2F%2F74.125.95.132%2Fsearch%3Fq%3Dcache%3A_D5mPzozc2I J%3Awww.gimptalk.com%2Fforum%2F-script-fu-efficient-rotating -%2526-cropping-tool-t32052.html%2Bscript-fu%2Befficient%2Bc ropping%2Brotating%2Btool%26cd%3D1%26hl%3Den%26ct%3Dclnk&ei= -AcNSs6-HZvMMIzdnLcG&usg=AFQjCNEPHJMcZdNESQ2G7123a3IN04Uh0w& sig2=rYkYIcfwZHEse-9-8zvxaA

I grabbed your script from flashingtwelve.brickfilms URL above, set a path with Path tool and when I ran it (GIMP 2.6.6 - Windows XP SP3) got this in the error console:

GIMP Error Calling error for procedure 'gimp-image-crop': Procedure 'gimp-image-crop' has been called with value '-160' for argument 'offx' (#4, type GimpInt32). This value is out of range.

GIMP Warning Plug-In 'Rotate To Path Point' left image undo in inconsistent state, closing open undo groups.

GIMP Error Execution error for 'Rotate To Path Point': Error: Procedure execution of gimp-image-crop failed on invalid input arguments: Procedure 'gimp-image-crop' has been called with value '-160' for argument 'offx' (#4, type GimpInt32). This value is out of range.

I notice that at the bottom of the original conversation the OP (StefanP) has a recent unanswered problem (Sun Apr 26, 2009 2:18 am) after updating to GIMP 2.6 (not exactly the same error as I got):

It is me again. After upgrading to Ubuntu 9.04 and Gimp 2.6 I am now getting the following error after setting the path and executing the script:

Execution error for 'Rotate To Path Point': Error: Bad syntax of binding spec in let* : ((vectors) (stroke-id) (points) (x1) (y1) (x2) (y2) (center-x) (center-y) (radius) (angle) (foo (car (gimp-image-get-filename image))))

Hi,

On Thu, 2009-05-14 at 15:04 +0200, Maciej Pilichowski wrote:

In GIMP there is such feature as rotate. This is of course useful but when correcting, you can say alignment, it is also useful to have ability to rotate image in such way that some point would make horizontal or vertical line.

User would click on one point on the image, then click on the second point, the dialog would appear and user would only select "horizontal alignment" or "vertical alignment". And the rest would be the Gimp

On Thu, 2009-05-14 at 10:46 -0700, Akkana Peck wrote:

Jay Smith writes:

My desire would be for:

click (on first point) click (on second point to finish the line) do a keystroke command that can be accomplished with ONE hand to execute the task (I would prefer not to have to hit the Enter key)

You could perhaps do this with a plug-in:

- Use the Paths tool - Click on first point, then on second point

This has already been done:

The discussion: http://forum.meetthegimp.org/index.php/topic,223.0.htm

and the current Python code: http://forum.meetthegimp.org/index.php?action=dlattach;topic=223.0;attach=328

It would still be a useful feature to add to the Rotate tool, and that discussion should continue; but since any change to a tool won't be available until the next major version, this might be a workaround that you could use right now.

This should be in the rotate tool. The grid is great, but sometimes I have some problems to align it properly.

Rolf http://meetthegimp.org

Hi,

This is Zhenfeng, a GSoC student on the following project...

Title: Advanced GUI for brush dynamics (GIMP) Student: Zhenfeng Zhao
Mentor: Kaja Liiv

I have not got in touch with my mentor, Kaja Liiv, yet. Could anyone give me Kaja's contract info? I have asked for it before. I hope to talk to Kaja as soon as possible to work on project milestones and dates. Thank you very much.

Regards,
Zhenfeng.

__________________

On Wednesday 20 May 2009 04:38:33 pm Nick Zhao wrote:

Hi,

This is Zhenfeng, a GSoC student on the following project...

Title: Advanced GUI for brush dynamics (GIMP) Student: Zhenfeng Zhao
Mentor: Kaja Liiv

/me waves. been meaning to contact you. seems you beat me.