Laurent MONIN wrote:

Hello,

the "fixed" option of the crop tool is far better now, aspect ratio is nicely working, thank you very much for what you did.

I noted few things (that you may already know): - in some cases, there are spurious lines drawn when defining the crop zone. - Fixed Aspect Ratio reports width:height which is great, but when changing to Fixed Width or Fixed Height, the value is set to 100, it would be more useful if it stayed on the previous width or height value. Fixed Size should be the one of the current crop zone, not 100x100

Thanks Laurent

Yup, bug 467972 (http://bugzilla.gnome.org/show_bug.cgi?id=467972) is the highlight artifacts bug.

Updating the Fixed: Width/Height entries would be nice indeed, and I plan to fix this before 2.4, I just haven't found the time to do so yet. Since I have already written the surrounding code, fixing this should go fairly quick.

I'm not sure what to put for Fixed: Size though, and the spec simply states 100x100 "but are open for improvments". "Crop zone" sounds interesting, what do you mean by that?

- Martin Nordholts

Martin Nordholts wrote:

Updating the Fixed: Width/Height entries would be nice indeed, and I plan to fix this before 2.4, I just haven't found the time to do so yet. Since I have already written the surrounding code, fixing this should go fairly quick.

Crap, just recalled why this isn't still done; the entry widgets used for Fixed: Width/Height is not the same as for Fixed: Aspect ratio/Size, and does not support a user-override mode, so you will unfortunately have to wait for 2.6 for automatically updated Fixed: Width/Height entries.

It would be easy to update Fixed: Size however, since that uses the same widget as Fixed: Aspect ratio, so I'm still curious about what you mean with "crop zone"

- Martin Nordholts

Liam R E Quin wrote:

It would be easy to update Fixed: Size however, since that uses the same widget as Fixed: Aspect ratio, so I'm still curious about what you mean with "crop zone"

I think it's fairly clear (although maybe I'm out to breakfast)... when you clidck on Fixed Size, the size (width + height fields) could be filled in from the current size of the crop preview rectangle, if there is one.

Sounds to me as if you need to svn up and rebuild :) Fixed size is no longer specified using separate Width and Height entries, instead, a so called GimpNumberPairEntry is used.

It seems to me as if you describe Fixed: Size simply as a facility to lock the current size. That was the case before I started to implement guiguru's rectangle tools spec [1], but it's not the case anymore, so your argumentation is somewhat "out of date" (or I have misunderstood it).

There are some UI problems with this though. If I enter a width and height and then click fixed size, the crop rectangle preview probably needs to change, not the numbers I entered. So the dialogue would need to keep track of whether I had entered values into width and/or heigher since the state of Fixed Size was last changed, and retain those if so. I think?

For handling Fixed: Width/Height, what the spec says makes most sense imo. Thew new GimpNumberPairEntry widget has what you are asking for, a "user override mode", and a "default values mode", please refer to spec for details. The problem is that the Fixed: Width/Height entry widgets do not have that functionality yet, and there lies the problem.

- Martin Nordholts

[1] http://gui.gimp.org/index.php/Selection_%2B_crop_tool_specification

Liam R E Quin wrote:

On Tue, 2007-08-21 at 08:34 +0200, Martin Nordholts wrote:

However, with latest svn it's still frustrating: (1) open a medium-sized image, e.g. 1000x3000 pixels (2) press C to choose crop tool, and drag out a rectangle of (say) several hundred pixels on a side (3) in tool options, check Fixed
(4) next to Fixed, choose Size from the pulldown (5) the numbers 100x100 appear, and the Width and Height fields are (extremely annoyingly) greyed out so you can't copy and paste the numbers.
(6) if you try and move the rectangle now you've got it to the size you wanted, it will spring to 100x100. Start over.

Liam

Well, you could just uncheck Fixed: Size and do the copy-pasting.

Moving the rectangle should indeed not change size of the rectangle, so that is a bug. Will be fixed.

- Martin Nordholts

peter sikking wrote:

Guys,

Hello guiguru,

(It was an odd time stamp on your mail. are you back from vacation yet?)

The spec asks for ideas for good default values for the Fixed: Size entries.

How about having 100x100 as default when there is no pending rectangle and rectangle width x rectangle height when there is one? This would be the case for both the selection tools and the crop tool.

I see two good things about making it this way:

1) It would be easy to fix the current rectangle shape so that one does not accidentally resize it.

2) It would be easy to duplicate a "perfect size" many times, like when one does not know the correct size for the rectangle but have to experiment a bit on the canvas first to get the desired size of the rectangle.

Once you have this "perfect size", it would be easy to use the size in many places.

- Martin Nordholts

suddenly I am in Kansas, on a very cool project for 2 weeks.

I hope you had a good vacation :)

How about having 100x100 as default when there is no pending rectangle and rectangle width x rectangle height when there is one? This would be the case for both the selection tools and the crop tool.

we cannot base the default of fixed size on the current rect, because it operates on the current rect. This would freeze up the rect in a positive feedback cycle.

we can base it on the image size, but that would make no sense for fixed size.

It seems as if quite a lot of people would like there to be a way of fixing the size of a pending rectangle.

If we handled the default values of Fixed: Size the same way as for the default values of the Fixed: Aspect ratio entry (i.e. when rubber banding has ended, set the default width/height to the pending rectangle width/height) that would allow people to more intuitively fix the current rectangle.

Use case:

A user create a rectangle and adjusts size to whatever is the size the user desires in a given context.

To avoid accidental resize of the rectangle, the user would like to fix the current size.

Since the default values for Fixed: Size are updated to that of the pending rectangle when rubber-banding has ended, the values in the Fixed Size entry are that of the current pending rectangle (if the entry is not in user-overridden mode, of course).

So, to fix the current size, the user only have to check the Fixed: Size checkbox.

If the user wishes to adjust the size a bit, he/she can simply do that in the Fixed: Size entry.

With defaults always as 100x100, it is annoying to adjust the Fixed: Size since 100x100 is likely to be far from what the current rectangle is. To adjust e.g. only the height, the user would have to manually enter *both* the current values in the Width: and Height: entries, which can be tedious with 4 digit width/height sized rectangles.

If we did this like described, there would be no positive feedback cycle freeze, right? Or is it something I am disregarding? To me this sounds as a pretty good way of allowing the users to fix the size

- Martin

Akkana Peck wrote:

Martin Nordholts writes:

It seems as if quite a lot of people would like there to be a way of fixing the size of a pending rectangle.

If we handled the default values of Fixed: Size the same way as for the default values of the Fixed: Aspect ratio entry (i.e. when rubber banding has ended, set the default width/height to the pending rectangle width/height) that would allow people to more intuitively fix the current rectangle.

Here's a counter-argument. Suppose I need to make a whole bunch of fixed size images (perhaps for a slide show or to fill in spaces in a grid). I set the Fixed Size entry to 640x480 (or whatever) and make a few of them. But then I need to make some other adjustment involving a crop or rect select. I un-check Fixed, make my selection, and now I've lost the 640x480 and I'll have to type it in again.

First and foremost, each rectangle tool, Rectangle/Ellipse Select and Crop, have its own tool options, so a certain Fixed: Size in th Crop Tool will not affect the Fixed: Size in e.g. the Rectangle Select Tool.

Second of all, the problem you describe is actually solved (it was an integral part of guigurus new rectangle tools redesign).

All Fixed: Size and Fixed: Aspect ratio entries have two modes, user-overriden and automatic.

When in automatic mode, the numbers change whenever the default values change.

When in user-overriden mode, the number are unchanged until the user clears the textbox, in which case the entry goes back into automatic mode. User-overriden mode is entered whenever the user explicitly enters a value.

So, if you have explicitly entered a value for Fixed: Size, you are guaranteed that it will never change, until you clear the textbox and set the entry in automatic mode again.

Currently, only the Fixed: Aspect ratio of th Crop tool gets constantly updated default values, namely to the size of the image/layer when there is no pending rectangle, and the size of the pending crop rectangle when there is one.

You can see whether or not a Fixed: Size/Apsect ratio entry is in automatic mode or not; when the text is italic, it is in automatic mode. A normal font indicates user-overridden mode.

It is because of this automatic/user-overriden mode functionality that I think what I suggested will work, but I am of course still looking for other counter-arguments :)

- Martin Nordholts