Hi,

On Mon, 2006-09-18 at 09:18 +1000, Paul L Daniels wrote:

I've written a stand-alone converter for Adobe Illustrator palette files (.ai) to GIMP palette files.

This was written because I do vinyl cutting/signs and the various makers of the vinyl (Avery etc) produce palette files based on their available colours. Clearly it's advantageous/simpler to use their palettes rather than trying to go through the whole spot matching process.

GIMP already supports import of a variety of palette formats. The code for this is in app/core/gimppalette-import.c. Perhaps you or someone else would want to try to include your code here?

Sven

From: Paul L Daniels

Hello everyone,

This is my first ever "GIMP" related programming project.

I've written a stand-alone converter for Adobe Illustrator palette files (.ai) to GIMP palette files.

Hi Paul,

Thanks for the contribution. Probably the best way to keep this from getting lost would be to file an enhancement request in Bugzilla and attach your code to it.

The ideal thing would be to incorporate the code into GIMP itself by working it into app/core/gimppalette-import.c, which is the code that detects and loads palette files in several formats. If you don't feel like doing this, somebody else might be able to, so long as your license is compatible with code being extracted and inserted into a GPL-licensed program -- it does not look to me like that's the case right now, but I may be wrong.

Best wishes,

-- Bill

______________ ______________ ______________ ______________ Sent via the CNPRC Email system at primate.ucdavis.edu

Hi,

On Mon, 2006-09-18 at 21:05 +1000, Paul L Daniels wrote:

GIMP already supports import of a variety of palette formats. The code for this is in app/core/gimppalette-import.c. Perhaps you or someone else would want to try to include your code here?

Okay, I'll take a look at it. Does this code convert existing palettes into /gimp/ palettes or does it persistently decode them each time?

The code imports the palette. This means it's loaded in GIMP then and can be saved as a GIMP palette.

I am not sure why we are doing it this way at all. Gradients are transparently loaded from two different formats (GIMP's native one and SVG). We could do this for palettes as well and just load all supported palette formats on startup. But this is not really relevant now. You can add the code to load Illustrator palettes to the current framework now and we can consider to change it later.

Sven

Hi,

On Wed, 2006-09-20 at 10:31 +1000, Paul L Daniels wrote:

I'll give it a shot (already have the file open and have started to edit it). Although I should probably ask elsewhere, would I be better to create an external module (.[cho]) with the AI palette import code, or put the code within the actual gimppalette-import.c code ? ie, I could create a module/object gimppalette-import-ai.[cho] .

It would probably not hurt to split all the different palette loaders into separate files.

Sven

Hi,

On Wed, 2006-09-20 at 16:44 +1000, Paul L Daniels wrote:

One question I did have is that the AI Palette entries are defined with floating point values for RGB, I presume that currently GIMP supports only the usual 24 bit RGB triples (ie, 0-255 per channel)?

GIMP uses a structure called GimpRGB that stores RGB and alpha as doubles ranging from 0 to 1. See
http://developer.gimp.org/api/2.0/libgimpcolor/libgimpcolor-GimpRGB.html

By the way, are you working with CVS or a recent development release?

Sven

Hi,

On Wed, 2006-09-20 at 17:30 +1000, Paul L Daniels wrote:

Using the latest "stable" (2.2.13) release - is there a release that would be preferential in this situation?

In this particular case, it probably doesn't make much of a difference. But it will be easier to incorporate your code if you base it on the CVS HEAD branch or GIMP 2.3.11.

Sven

On Wed, 2006-09-20 at 08:40 +0200, Sven Neumann wrote:

On Wed, 2006-09-20 at 10:31 +1000, Paul L Daniels wrote:

I'll give it a shot (already have the file open and have

started to edit it). Although I should probably ask elsewhere, would I be better to create an external module (.[cho]) with the AI palette import code, or put the code within the actual gimppalette-import.c code ? ie, I could create a module/object gimppalette-import-ai.[cho] .

It would probably not hurt to split all the different palette loaders into separate files.

It should go to gimppalette-load.[ch], together with the standard palette loader function. Look at how the gradient loading/saving files are organized, and how gimp_real_initialize() in app/core/gimp.c maps file extensions to data load handlers.

ciao, --mitch

Hi,

On Wed, 2006-09-20 at 12:11 +0200, Michael Natterer wrote:

It should go to gimppalette-load.[ch], together with the standard palette loader function. Look at how the gradient loading/saving files are organized, and how gimp_real_initialize() in app/core/gimp.c maps file extensions to data load handlers.

Please don't confuse Paul. This is something that we can do at a later point. Currently we only load the GIMP palette format and other formats are handled by the import function. If we want to change that, fine. But the new format should first be added where the other palette formats are handled.

Sven