Stephan Menzel (stephan42@chinguarime.net) wrote: [...]
(Nothing to say about your first point)

2. The new 'Crop' tool is not as simple as the old. Formerly there used to be a border that opens and you could drag the corners around until they finally matched what you wanted and then you pressed the crop button. There was a shortcut too. (Ctrl+c?) Now the shortcut seems to be gone and there are no longer dragable corners.

I think the shortcut is Shift-C, and I don't think that changed. You also can assign a different shortcut when enabling "dynamic keyboard shortcuts" in the preferences, hovering your mouse over Tools->Transform Tools->Crop & Resize and press the new shortcut.

Also I don't think that there something has fundamentally changed in the handling of the tool itself. It surely still has the edges (for resizing and moving the rectangle). I don't know what happens for you there.

Maybe try again? And if it really doesn't work describe more clearly what you are doing and what is different from what you expect.

Bye, Simon

Hi,

Stephan Menzel writes:

1. Whenever I click on the 'Insert Text' Button, the foreground color as well as the color for the text itself changes to black. Though it is possible to use another color it is much more complicated than before (1.2.2). Why? I often pick a color out of the picture with this little colorpickertool and then insert text in this color that matches another in the picture. Black is the least I would use. But now this is complicated and rather a pain. Does this change have any purpose I just don't see? Anyway, if it doesn't, can you change that back in the next release?

The foreground color is not supposed to change. If it really does, that would be a bug. However I don't seem to able to reproduce this.

2. The new 'Crop' tool is not as simple as the old. Formerly there used to be a border that opens and you could drag the corners around until they finally matched what you wanted and then you pressed the crop button. There was a shortcut too. (Ctrl+c?) Now the shortcut seems to be gone and there are no longer dragable corners. You have to use rectangular selection instead which doesn't have this. (Or does it?) And when I choose 'crop' in the menu, there is a new selection just slightly smaller than the picture over almost the entire crop. I can't really see the purpose for that. The cropped image seems to be slightly larger than the area I actually selected too.

I am sorry but the crop tool didn't change at all. You should still be able to drag the corners just as in GIMP 1.2. We only added a convenient way to crop the image to the size of the current selection (Image->Crop Image) but that's not really related.

Sven

On Mon, 2004-05-10 at 18:53, Stephan Menzel wrote:

Well, it does here.
I can reproduce it every time.
0. Load Gimp and load any picture (tried with RGB and Greyscale) 1. press O
2. pick a color from the picture
3. close the little color chooser window 4. press T or click the Text button
- -> The forgroundcolor is black again and so is the text.

It is a bug (IMO). I see the same problem with 2.0.1 but not in the 2.1 version. In 2.1 I can click a pick a colour then select the text tool without the foreground colour changing.

Sven Neumann wrote:

Hi,

Stephan Menzel writes:

1. Whenever I click on the 'Insert Text' Button, the foreground color as well as the color for the text itself changes to black. Though it is possible to use another color it is much more complicated than before (1.2.2). Why? I often pick a color out of the picture with this little colorpickertool and then insert text in this color that matches another in the picture. Black is the least I would use. But now this is complicated and rather a pain. Does this change have any purpose I just don't see? Anyway, if it doesn't, can you change that back in the next release?

The foreground color is not supposed to change. If it really does, that would be a bug. However I don't seem to able to reproduce this.

This is an issue with the per-tool contexts.

If you select a colour with the colour picker, then select the text tool, the text tool will have a black foreground (its own context). However, it doesn't affect the background. This is confusing, because it means that using the colour picker to pick a text colour involves picking the colour, opening the colour chooser and saving it, setting the text tool, opening the colour chooser for the text tool, and loading the saved colour. Which is complicated.It would be nicer (imho) if the text tool used the active FG if it hadn't been set yet, rather than defaulting to black.

If you look at this from the point of view of someone coming from 1.2, this problem is obvious.

Cheers,
Dave.

Hi,

Dave Neary wrote:

It would be nicer (imho) if the
text tool used the active FG if it hadn't been set yet, rather than defaulting to black.

The proper way to do this, I suppose, would be to get rid of the "color" option from the text tool options, and just use the foreground in the same way as the other paint tools use it (keep it in the context, but don't set it by default).

Cheers, Dave.

Hi,

Dave Neary writes:

This is an issue with the per-tool contexts.

This is not an issue, it's a bug and should be reported in Bugzilla.

If you select a colour with the colour picker, then select the text tool, the text tool will have a black foreground (its own context). However, it doesn't affect the background. This is confusing, because it means that using the colour picker to pick a text colour involves picking the colour, opening the colour chooser and saving it, setting the text tool, opening the colour chooser for the text tool, and loading the saved colour. Which is complicated.It would be nicer (imho) if the text tool used the active FG if it hadn't been set yet, rather than defaulting to black.

Sorry, but that's definitely not how it works nor how it's supposed to work.

Sven

Hi,

Stephan Menzel writes:

Well, it does here.
I can reproduce it every time.
0. Load Gimp and load any picture (tried with RGB and Greyscale) 1. press O
2. pick a color from the picture
3. close the little color chooser window 4. press T or click the Text button
-> The forgroundcolor is black again and so is the text. As I said,

I had a closer look and it does indeed not behave as it should. So this is clearly a bug.

I use version 2.0.1, which works fine, besides this. If it really is a bug. It wouldn't be so bad if I could choose a new color from the textcolorwidget but there is only the color dialog which is inconvenient. I prefer 'o'.

You don't have to use the color dialog that you open from the text tool options. Simply drag a color on the color button to change the text color.

Sven

Hi,

It would be nicer (imho) if the text tool used the active FG if it hadn't been set yet, rather than defaulting to black.

That's exactly how it is supposed to work.
Dave Neary writes:

The proper way to do this, I suppose, would be to get rid of the "color" option from the text tool options, and just use the foreground in the same way as the other paint tools use it (keep it in the context, but don't set it by default).

Nope, that won't work. The text tool is supposed to use the foreground color unless it is being used on an already existing text layer. In that case it needs to use the color of the text layer and that's why the color button is needed.

All that needs to be done here is to get the bug fixed and resurrect the intended behaviour.

Sven

Hi,

Stephan Menzel writes:

The proper way to do this, I suppose, would be to get rid of the "color" option from the text tool options, and just use the foreground in the same way as the other paint tools use it (keep it in the context, but don't set it by default).

Exactly. This is how it used to be and this is how it should be. The extra color option in the text options is not needed.

As I already explained in a previous mail, Dave is wrong here and the color button is needed. The way it used to be there wasn't the concept of editable text layers. With the introduction of text layers the color button became necessary.

Sven

Hi,

Stephan Menzel writes:

Does that mean, that this color must default to black as well? There can be an extra color button in that dialog, no worries, but couldn't it default to the picked foreground color when this text layer is created in the first place? Or is that how it is supposed to be?

I thought I explained that already. Unless a text layer is selected, the color button in the text tool options is supposed to stay in sync with the foreground color. That's how it works in the HEAD branch. I am not sure when and why it broke in gimp-2.0.

Sven