Hi,

Tim Newsome writes:

A while back I wanted to open this huge satellite image I downloaded from NASA, and the Gimp required more than 2Gb of swap space. It didn't work, so I wrote a new tile-swap.c which makes additional swap files once the current one hits 1Gb.

this shouldn't be necessary since the current code should handle large swap files (see http://bugzilla.gnome.org/show_bug.cgi?id=74478).

Also, the following diff
needs to be aplpied:

--- gimp-1.3.7/app/base/tile-private.h 2001-12-03 05:44:50.000000000 -0800 +++ gimp-1.3.7-tiles/app/base/tile-private.h 2002-08-03 18:59:37.000000000 -0 700
@@ -76,7 +76,7 @@
* for swapping. swap_num 1 is always the global * swap file.
*/
- off_t swap_offset; /* the offset within the swap file of the tile data. + guint64 swap_offset;/* the offset within the swap file of the tile data. * if the tile data is in memory this will be set to -1. */
TileLink *tlink;

IMO off_t is the correct type here. Since we use AC_SYS_LARGEFILE, off_t should be 64 bits long if your OS supports such large files. guint64 is definitely wrong since an offset should always be a signed value.

Salut, Sven

Hi,

Tim Newsome writes:

On Fri, Sep 13, 2002 at 04:56:57PM +0200, Sven Neumann wrote:

A while back I wanted to open this huge satellite image I downloaded from NASA, and the Gimp required more than 2Gb of swap space. It didn't work, so I wrote a new tile-swap.c which makes additional swap files once the current one hits 1Gb.

this shouldn't be necessary since the current code should handle large swap files (see http://bugzilla.gnome.org/show_bug.cgi?id=74478).

But that requires file system support for >2Gb files. My patch doesn't.

is that a real-world problem? I mean are people really working with large images and use filesystems that don't support files >2GB ? I wouldn't like to do significant changes to the tile swap code without a really good reason.

Salut, Sven

I rather like Tim's idea, since it works even on systems where large file support is not available. If his approach works, I see no reason not to use it.

Kelly

----- Original Message ----- From: "Tim Newsome"
To:
Sent: Friday, September 13, 2002 10:54 AM Subject: Re: [Gimp-developer] new tile-swap.c

On Fri, Sep 13, 2002 at 04:56:57PM +0200, Sven Neumann wrote:

A while back I wanted to open this huge satellite image I downloaded from NASA, and the Gimp required more than 2Gb of swap space. It didn't work, so I wrote a new tile-swap.c which makes additional swap files once the current one hits 1Gb.

this shouldn't be necessary since the current code should handle large swap files (see http://bugzilla.gnome.org/show_bug.cgi?id=74478).

But that requires file system support for >2Gb files. My patch doesn't.

Tim --
Tim Newsome nuisance@casualhacker.net http://www.wiw.org/~drz/ And we have just one world / But we live in different ones