RSS/Atom feed Twitter
Site is read-only, email is disabled
  1. Chat
  2. Useful links
  3. Polls

Featured content

Patch: GIO dependency made optionnal

This discussion is connected to the gegl-developer-list.gnome.org mailing list which is provided by the GIMP developers and not related to gimpusers.com.

This is a read-only list on gimpusers.com so this discussion thread is read-only, too.

5 of 5 messages available
Toggle history

Please log in to manage your subscriptions.
Patch: GIO dependency made optionnal Hubert Figuiere 17 May 22:22
  Patch: GIO dependency made optionnal Øyvind Kolås 17 May 22:38
Patch: GIO dependency made optionnal Geert Jordaens 18 May 00:59
Patch: GIO dependency made optionnal Øyvind Kolås 18 May 12:42
Patch: GIO dependency made optionnal Sven Neumann 18 May 15:22
Hubert Figuiere
2008-05-17 22:22:53 UTC (over 16 years ago)

Patch: GIO dependency made optionnal

Hi

Here is my initial patch for GEGL to make gio an optional dependency for those who run an already obsolete version of glib.

The only non-trivial part is GFileMonitor, and I actually scraped that part.

Also another caveat is that I had to change the prototype of two functions that wanted a GInputStream *.

Any comment?

Hub

PS: there might also be some indent issues. Will fix them.

Øyvind Kolås
2008-05-17 22:38:03 UTC (over 16 years ago)

Patch: GIO dependency made optionnal

On Sat, May 17, 2008 at 9:22 PM, Hubert Figuiere wrote:

Here is my initial patch for GEGL to make gio an optional dependency for those who run an already obsolete version of glib.

This isn't only about obsolete versions of glib since there is no version having a GIO
supporting all the features GeglBuffer would want it to, see bug #533547. Thus unless
this gets resolved in glib we might have to fall back to regular posix calls anyways.

The only non-trivial part is GFileMonitor, and I actually scraped that part.

Could be reimplemented using polling, or perhaps even better using mmap for at least the buffer header.

Also another caveat is that I had to change the prototype of two functions that wanted a GInputStream *.

These are internal for now so it isn't an issue.

Any comment?

Commit this change at will to GEGL when you think it has recevied enough polish.

/Øyvind K.

Geert Jordaens
2008-05-18 00:59:04 UTC (over 16 years ago)

Patch: GIO dependency made optionnal

Is what you are trying to do for gegl_buffer not possible with the GIOChannel?

Øyvind Kolås wrote:

On Sat, May 17, 2008 at 9:22 PM, Hubert Figuiere wrote:

Here is my initial patch for GEGL to make gio an optional dependency for those who run an already obsolete version of glib.

This isn't only about obsolete versions of glib since there is no version having a GIO
supporting all the features GeglBuffer would want it to, see bug #533547. Thus unless
this gets resolved in glib we might have to fall back to regular posix calls anyways.

The only non-trivial part is GFileMonitor, and I actually scraped that part.

Could be reimplemented using polling, or perhaps even better using mmap for at least the buffer header.

Also another caveat is that I had to change the prototype of two functions that wanted a GInputStream *.

These are internal for now so it isn't an issue.

Any comment?

Commit this change at will to GEGL when you think it has recevied enough polish.

/Øyvind K.

Øyvind Kolås
2008-05-18 12:42:14 UTC (over 16 years ago)

Patch: GIO dependency made optionnal

On Sat, May 17, 2008 at 11:59 PM, Geert Jordaens wrote:

Is what you are trying to do for gegl_buffer not possible with the GIOChannel?

It probably is, but I would like to use one API to do this, namely the GIO API and start out with a GFile. I guess the port to GIO was premature, since this part of the code at some point might want to do quite a lot of it's work using mmap instead of reads/writes as well.

Using GIO on the other hand would be very sweet if it worked.

/Øyvind K.

Sven Neumann
2008-05-18 15:22:09 UTC (over 16 years ago)

Patch: GIO dependency made optionnal

Hi,

On Sat, 2008-05-17 at 21:38 +0100, Øyvind Kolås wrote:

On Sat, May 17, 2008 at 9:22 PM, Hubert Figuiere wrote:

Here is my initial patch for GEGL to make gio an optional dependency for those who run an already obsolete version of glib.

I don't think this should be applied. An optional dependency in the GEGL core will cause code duplication and it bears the risk that versions of GEGL compiled against different versions of glib will behave differently. I don't see the point in doing this.

This isn't only about obsolete versions of glib since there is no version having a GIO
supporting all the features GeglBuffer would want it to, see bug #533547. Thus unless
this gets resolved in glib we might have to fall back to regular posix calls anyways.

If that happens, that is fine. But it should IMO not be optional. et's not make the code more complex for no good reason. At the time that GEGL will be useful enough to be actually used, glib with GIO will be available everywhere.

Sven