Yay! Finally! :)

Mukund, couple of points.

I can save a 16-bit tiff. However, unlike other image processing apps, Gimp won't tell me if it's saving as 16-bit or 8-bit. I did save and then opened in Gimp 2.8.4 and determined that the saved file is indeed 16-bit.

Would it be possible to add this to the tiff export dialog? That is give the user the option to export as 8-bit or 16-bit in addition to the current compression options.

For PNG, I got a failed to save png struct which may or may not be an issue on my side. I am currently on version 1.6.2. Which version of PNG did you test on?

BTW, I have currently only tested on a Macbook pro running Mountain Lion.

Did I say that you guys rock?? I say it on my website all the time. :)

On Fri, May 24, 2013 at 4:19 AM, Mukund Sivaraman wrote:

Hi all

The following file plug-ins have been revised to use GIMP's new API. I feel they need more testing as the changes are intrusive and the file types can support a variety of pixel formats. I have tested these to my satisfaction. Please test these if you can (master branch).

* file-jpeg (test loading and saving grayscale and RGB JPEG files)

* file-tiff-save (test saving grayscale, RGB and indexed TIFF files incl. 16-bits per channel in the case of non-indexed)

* file-ps (test saving grayscale and RGB formats)

* I have reviewed file-png's load and save code (which was revised some time back by nomis) and it seems fine to me. But please test this one by using it too, as it's a commonly used plug-in. Test saving grayscale, RGB and indexed PNG files incl. 16-bits per channel in case of non-indexed.

Mukund

_______________________________________________ gimp-developer-list mailing list
gimp-developer-list@gnome.org
https://mail.gnome.org/mailman/listinfo/gimp-developer-list

On 5/24/13, Mukund Sivaraman wrote:

The following file plug-ins have been revised to use GIMP's new API. I feel they need more testing as the changes are intrusive and the file types can support a variety of pixel formats. I have tested these to my satisfaction. Please test these if you can (master branch).

* file-tiff-save (test saving grayscale, RGB and indexed TIFF files incl. 16-bits per channel in the case of non-indexed)

Tiff vary a bit in their internal structure, depending on which software generates the tiff, yes? So I'm planning on testing tiffs from several sources.

I'm using Gentoo Linux. I rebuilt babl, gegl, and Gimp 2.9 from git this morning. So far I've tested some old 8-bit and 16-bit single layer tiffs that were created using Photoshop CS2 under Windows 2K (I did say old!):

*8-bit and 16-bit color tiffs opened and exported properly; I was able to open the exported files with showFoto and each file looked right and had its appropriate bit depth.

*converting 8-bit tiff to 16-bit tiff and exporting worked.

*converting tiff to indexed and exporting worked.

*converting 8-bit and 16-bit color tiffs to grayscale and exporting worked; the exported file opened with showFoto and looked exactly as expected. However, opening the exported 8-bit and 16-bit color-to-grayscale tiffs (that Gimp has just exported) with Gimp instead of showFoto didn't work. The images were too light in tonality, looked like they had been given a gamma 2.2ish correction. Upon exporting the newly opened grayscale image under a new name, the exported image then was also wrong in showFoto (showFoto can't actually work with or save grayscale image, instead converts to RGB before displaying the image).

*Tiffs can support multiple layers and higher than 16-bit precision, which is not to say that Gimp is obligated to support these options. Exporting a two-layer tiff didn't work. Only one layer was exported and only about a third of the image on that layer was exported properly. Also changing precision to 32-bit floating point and exporting as a tiff resulted in a 16-bit tiff.

Elle

Hi Mukund,

Thanks for the work done! I will run some tests too at some point... By the way, I have a pending patch related to file-bmp:

https://bugzilla.gnome.org/show_bug.cgi?id=674391

Could you please (or anyone) review it? It would be great if it could benefit from that testing moment too.

Thanks,

Téo

Le 2013-05-24 10:19, Mukund Sivaraman a écrit :

Hi all

The following file plug-ins have been revised to use GIMP's new API. I feel they need more testing as the changes are intrusive and the file
types can support a variety of pixel formats. I have tested these to my
satisfaction. Please test these if you can (master branch).

* file-jpeg (test loading and saving grayscale and RGB JPEG files)

* file-tiff-save (test saving grayscale, RGB and indexed TIFF files incl. 16-bits per channel in the case of non-indexed)

* file-ps (test saving grayscale and RGB formats)

* I have reviewed file-png's load and save code (which was revised some
time back by nomis) and it seems fine to me. But please test this one
by using it too, as it's a commonly used plug-in. Test saving grayscale, RGB and indexed PNG files incl. 16-bits per channel in case
of non-indexed.

Mukund

_______________________________________________ gimp-developer-list mailing list
gimp-developer-list@gnome.org
https://mail.gnome.org/mailman/listinfo/gimp-developer-list

Thank you, Mukund, for your work!

I updated the GEGL porting matrix [1]. To keep track of the test results I added columns for the test results. The matrix is straightforward to read and edit. Testers, feel free to test and update the wiki or let us know here about the results.

The same is if somebody knows a new porting state that isn't updated in the matrix yet.

Kind regards,

Sven

[1] http://wiki.gimp.org/index.php/Hacking:Porting_filters_to_GEGL

Elle:
I think I just fixed the two issues you mentioned (exporting with layers and importing grayscale tiffs). Could you grab the latest code and test those again, to confirm that they're fixed?

(Note that there's an additional problem related to importing with premultiplied alpha that I'll haven't fixed yet.)

-- drawoc

On Fri, May 24, 2013 at 1:03 PM, Elle Stone wrote:

On 5/24/13, Mukund Sivaraman wrote:

The following file plug-ins have been revised to use GIMP's new API. I feel they need more testing as the changes are intrusive and the file types can support a variety of pixel formats. I have tested these to my satisfaction. Please test these if you can (master branch).

* file-tiff-save (test saving grayscale, RGB and indexed TIFF files incl. 16-bits per channel in the case of non-indexed)

Tiff vary a bit in their internal structure, depending on which software generates the tiff, yes? So I'm planning on testing tiffs from several sources.

I'm using Gentoo Linux. I rebuilt babl, gegl, and Gimp 2.9 from git this morning. So far I've tested some old 8-bit and 16-bit single layer tiffs that were created using Photoshop CS2 under Windows 2K (I did say old!):

*8-bit and 16-bit color tiffs opened and exported properly; I was able to open the exported files with showFoto and each file looked right and had its appropriate bit depth.

*converting 8-bit tiff to 16-bit tiff and exporting worked.

*converting tiff to indexed and exporting worked.

*converting 8-bit and 16-bit color tiffs to grayscale and exporting worked; the exported file opened with showFoto and looked exactly as expected. However, opening the exported 8-bit and 16-bit color-to-grayscale tiffs (that Gimp has just exported) with Gimp instead of showFoto didn't work. The images were too light in tonality, looked like they had been given a gamma 2.2ish correction. Upon exporting the newly opened grayscale image under a new name, the exported image then was also wrong in showFoto (showFoto can't actually work with or save grayscale image, instead converts to RGB before displaying the image).

*Tiffs can support multiple layers and higher than 16-bit precision, which is not to say that Gimp is obligated to support these options. Exporting a two-layer tiff didn't work. Only one layer was exported and only about a third of the image on that layer was exported properly. Also changing precision to 32-bit floating point and exporting as a tiff resulted in a 16-bit tiff.

Elle _______________________________________________ gimp-developer-list mailing list
gimp-developer-list@gnome.org
https://mail.gnome.org/mailman/listinfo/gimp-developer-list

The premultiplied alpha issue should now also be fixed.

On Fri, May 24, 2013 at 10:10 PM, Michael Henning wrote:

Elle:
I think I just fixed the two issues you mentioned (exporting with layers and importing grayscale tiffs). Could you grab the latest code and test those again, to confirm that they're fixed?

(Note that there's an additional problem related to importing with premultiplied alpha that I'll haven't fixed yet.)

-- drawoc

On Fri, May 24, 2013 at 1:03 PM, Elle Stone wrote:

On 5/24/13, Mukund Sivaraman wrote:

The following file plug-ins have been revised to use GIMP's new API. I feel they need more testing as the changes are intrusive and the file types can support a variety of pixel formats. I have tested these to my satisfaction. Please test these if you can (master branch).

* file-tiff-save (test saving grayscale, RGB and indexed TIFF files incl. 16-bits per channel in the case of non-indexed)

Tiff vary a bit in their internal structure, depending on which software generates the tiff, yes? So I'm planning on testing tiffs from several sources.

I'm using Gentoo Linux. I rebuilt babl, gegl, and Gimp 2.9 from git this morning. So far I've tested some old 8-bit and 16-bit single layer tiffs that were created using Photoshop CS2 under Windows 2K (I did say old!):

*8-bit and 16-bit color tiffs opened and exported properly; I was able to open the exported files with showFoto and each file looked right and had its appropriate bit depth.

*converting 8-bit tiff to 16-bit tiff and exporting worked.

*converting tiff to indexed and exporting worked.

*converting 8-bit and 16-bit color tiffs to grayscale and exporting worked; the exported file opened with showFoto and looked exactly as expected. However, opening the exported 8-bit and 16-bit color-to-grayscale tiffs (that Gimp has just exported) with Gimp instead of showFoto didn't work. The images were too light in tonality, looked like they had been given a gamma 2.2ish correction. Upon exporting the newly opened grayscale image under a new name, the exported image then was also wrong in showFoto (showFoto can't actually work with or save grayscale image, instead converts to RGB before displaying the image).

*Tiffs can support multiple layers and higher than 16-bit precision, which is not to say that Gimp is obligated to support these options. Exporting a two-layer tiff didn't work. Only one layer was exported and only about a third of the image on that layer was exported properly. Also changing precision to 32-bit floating point and exporting as a tiff resulted in a 16-bit tiff.

Elle _______________________________________________ gimp-developer-list mailing list
gimp-developer-list@gnome.org
https://mail.gnome.org/mailman/listinfo/gimp-developer-list

Pngs, tiffs, jpegs:

I did some more testing. I tried opening an assortment of pngs, jpegs, and tiffs created by a variety of image editing programs (recent versions of krita, cinepaint, showfoto, an older version of Photoshop, and test images downloaded from the web), and Gimp opened them all with no problem.

I more or less randomly tested changing the bit depth, changing to indexed, and changing to grayscale various tifs, jpegs, and pngs created by the various image editing programs and then exporting to tif, jpeg, and png at various bit-depths. Gimp opens its own exported files with no problems, as does showFoto, Cinepaint, and Krita.

The only issues I encountered have to do with multi-layer/page tiffs. I don't know what is the difference between multilayer and multipage tiffs, if there even is one. However, they are useful when blending panoramas and HDR images created by hugin. And Photoshop and Cinepaint both can export multilayer/page tiffs.

Gimp did properly import a multilayer/page tiff created by Cinepaint. The order of the layers was reversed. I didn't try any layered images with masks, though one image had three layers and alpha channels.

Gimp doesn't export a multilayer file as a multilayer/page tiff, rather flattens before exporting.

As previously noted, if Gimp flattens/exports a 2-layer grayscale (as opposed to color) tiff, showFoto can't open it.

Bottom line, with the possible exception of multilayer/page tiffs (depending on what kind of support Gimp is supposed to have - import seems good, export not), Gimp png, jpeg, and tiff file formats all look/work just fine.

BMPs:

I also downloaded a couple of bmps from the web and converted them to indexed, grayscale; converted them from sRGB to other ICC color spaces; exported as pngs, jpgs, tiffs; and also exported one tiff as a bmp.

I've never actually used a bmp, so I didn't know what to expect. But everything seemed normal, except in the advanced options there is an option to not embed color information, which I never checked. Sometimes it seemed like after converting to another color space, exporting, and reopening, the color space information was intact/honored. Other times I needed to assign the right profile to get the right colors. Someone who actually uses and understands bmps should also check!

Elle

http://ninedegreesbelow.com - articles on open source digital photography

Bottom line, with the possible exception of multilayer/page tiffs (depending on what kind of support Gimp is supposed to have - import seems good, export not), Gimp png, jpeg, and tiff file formats all look/work just fine.

Thank you, Elle. I updated the GEGL porting matrix with your findings.

Kind regards,

Sven