RSS/Atom feed Twitter
Site is read-only, email is disabled

Patch and build for the save/export issue

This discussion is connected to the gimp-developer-list.gnome.org mailing list which is provided by the GIMP developers and not related to gimpusers.com.

This is a read-only list on gimpusers.com so this discussion thread is read-only, too.

9 of 10 messages available
Toggle history

Please log in to manage your subscriptions.

Patch and build for the save/export issue Simone Karin Lehmann 22 Nov 23:56
  Patch and build for the save/export issue Alberto Mardegan 23 Nov 07:44
   Patch and build for the save/export issue Simone Karin Lehmann 23 Nov 12:38
    50AF71C3.1090208@googlemail... 29 Nov 22:43
     Patch and build for the save/export issue Simone Karin Lehmann 29 Nov 22:40
    Patch and build for the save/export issue Simone Karin Lehmann 23 Nov 18:36
     Patch and build for the save/export issue Simone Karin Lehmann 24 Nov 08:30
  Patch and build for the save/export issue Michael Schumacher 23 Nov 08:50
   Patch and build for the save/export issue Matthew Miller 23 Nov 14:21
   Patch and build for the save/export issue Simone Karin Lehmann 23 Nov 16:04
Simone Karin Lehmann
2012-11-22 23:56:29 UTC (about 12 years ago)

Patch and build for the save/export issue

Hi everybody,

this all seems to become a more and more controversial discussion. But, IMO, argueing more and more heatedly brings us to nowhere.

I can fully understand all developers who care about preventing data loss. I do care too.

I can fully understand all users who get used to the 'traditional way'. I got used to it too.

So here's what I did.

I've written a patch which tries to prevent data loss as far as possible but still gives you some of the traditional behavior back. A binary package can be downloaded (Mac OS X only with all previously included 3rd party plugins)

This is the new behavior

a) Non-XCF non-JPEG images with only 1 layer can be saved via 'File - Save' with the original file format. The dirty flag is cleaned and so there's no dialog about unsaved changes if you close it after saving.

After exporting them, the image title and file name is not changed, so that you can repeatedly save it as long as there is only 1 layer.

This is basically the same as 'Overwrite'

b) For all other images - images with 2 or more layers, JPEGs, XCF, newly created ones - nothing is changed. Saving them will create a XCF

c) Save as / Export / Export to / Overwrite are not changed.

This should prevent data loss as far as possible while still allowing the most mentioned user scenario: opening - destructive editing in place - saving.

Feel free to try it to see it in action, hoping this will help to settle the quarrel.

The patch is attached. Here's the download link: http://switch.dl.sourceforge.net/project/gimponosx/GIMP%20Mountain%20Lion/Gimp-2.8.2-savex-MountainLion.dmg

Regards Simone Karin

Alberto Mardegan
2012-11-23 07:44:21 UTC (about 12 years ago)

Patch and build for the save/export issue

On 11/23/2012 01:56 AM, Simone Karin Lehmann wrote:

a) Non-XCF non-JPEG images with only 1 layer can be saved via 'File - Save' with the original file format. The dirty flag is cleaned and so there's no dialog about unsaved changes if you close it after saving.

Why are you excluding JPEG files? That is the most commonly used format by photographers, among whom are most of the users who dislike the new behaviour.

So, I'm afraid that your proposed change wouldn't help them (certainly not me).

Ciao,
Alberto

http://blog.mardy.it <- geek in un lingua international!
Michael Schumacher
2012-11-23 08:50:22 UTC (about 12 years ago)

Patch and build for the save/export issue

Von: Simone Karin Lehmann

a) Non-XCF non-JPEG images with only 1 layer can be saved via 'File - Save' with the original file format. The dirty flag is cleaned and so there's no dialog about unsaved changes if you close it after saving.

After exporting them, the image title and file name is not changed, so that you can repeatedly save it as long as there is only 1 layer.

This is basically the same as 'Overwrite'

This moves the debate to a later date, when every filter and operation used on an image will have become an op in a graph.

Will "the image has only one layer" still be a viable criterion at that time?

Regards, Michael

Simone Karin Lehmann
2012-11-23 12:38:36 UTC (about 12 years ago)

Patch and build for the save/export issue

On 23.11.2012, at 08:44, Alberto Mardegan wrote:

Why are you excluding JPEG files? That is the most commonly used format by photographers, among whom are most of the users who dislike the new behaviour.

I excluded JPEG mostly because I wanted to calm down developers and I shared their concerns about JPEG being a lossy file format....

So, I'm afraid that your proposed change wouldn't help them (certainly not me).

... but the longer I think about this issue, the more I agree with you. JPEG is in fact the most common used format by photographers (well, besides shooting RAW). So I'll change my patch and build a new version which will allow all non-XCF files with only one layer to be saved via File - Save.

Regards Simone Karin=

Matthew Miller
2012-11-23 14:21:16 UTC (about 12 years ago)

Patch and build for the save/export issue

On Fri, Nov 23, 2012 at 09:50:22AM +0100, Michael Schumacher wrote:

This moves the debate to a later date, when every filter and operation used on an image will have become an op in a graph.

At that point, save the graph to separate hidden file, for persistent undo across image saves.

Matthew Miller           mattdm@mattdm.org          
Simone Karin Lehmann
2012-11-23 16:04:21 UTC (about 12 years ago)

Patch and build for the save/export issue

On 23.11.2012, at 09:50, "Michael Schumacher" wrote:

Von: Simone Karin Lehmann

a) Non-XCF non-JPEG images with only 1 layer can be saved via 'File - Save' with the original file format. The dirty flag is cleaned and so there's no dialog about unsaved changes if you close it after saving.

After exporting them, the image title and file name is not changed, so that you can repeatedly save it as long as there is only 1 layer.

This is basically the same as 'Overwrite'

This moves the debate to a later date, when every filter and operation used on an image will have become an op in a graph.

Will "the image has only one layer" still be a viable criterion at that time?

From a developers point of view certainly not. From a users point of view, IMO, yes.

Having the user scenario in mind which I wanted to address with this patch 'opening - destructive editing in place - saving' is identical to 'opening - gegl op editing - saving - loosing the gegl graph'.

Whereas if an image has more than one layer it's far more evident that one wants to work non-destructive. So the criterion 'one layer nonXCF' is IMO still suitable to allow a destructive workflow.

Anyway, you can't totally prevent users from data loss as long as you support non-XCF formats and offer Export / Overwrite.

IMO it's all about finding a trade-off between 'restrictions to prevent data loss' and 'allowing common user scenarios'.

Regards Simone Karin

Simone Karin Lehmann
2012-11-23 18:36:14 UTC (about 12 years ago)

Patch and build for the save/export issue

Am 23.11.2012 um 13:38 schrieb Simone Karin Lehmann:

... but the longer I think about this issue, the more I agree with you. JPEG is in fact the most common used format by photographers (well, besides shooting RAW). So I'll change my patch and build a new version which will allow all non-XCF files with only one layer to be saved via File - Save.

... and here's the new patch which let you "save" JPEG too.

And the download link for the binary (Mac OS X only): http://switch.dl.sourceforge.net/project/gimponosx/GIMP%20Mountain%20Lion/Gimp-2.8.2-savex2-MountainLion.dmg

Regards Simone Karin

Simone Karin Lehmann
2012-11-24 08:30:30 UTC (about 12 years ago)

Patch and build for the save/export issue

... and here's the new patch which let you "save" JPEG too.

sorry, I forgot to attach it :-(

Here it is now.

Simone Karin

Simone Karin Lehmann
2012-11-29 22:40:33 UTC (almost 12 years ago)

Patch and build for the save/export issue

Am 23.11.2012 um 13:53 schrieb Tobias Oelgarte:

Could we not just change the behaviour of "save as" if the user sets an option (global option) that he wants to use the old style, unsafe solution at his own risk? So everyone can choose what he likes.

... I've made the patch a configurable option. Yu can switch it on or off in GIMP's Preferences -> Environment -> Saving Images. -> "Force to save only in XCF image format".

Here's the download link (Mac OS X only). http://switch.dl.sourceforge.net/project/gimponosx/GIMP%20Mountain%20Lion/Gimp-2.8.2-savex3-MountainLion.dmg

The patch is attached Maybe someone can build a patched GIMP on the other platforms.