RSS/Atom feed Twitter
Site is read-only, email is disabled
  1. Chat
  2. Useful links
  3. Polls

Featured content

[PATCH] Fix rect position when trasnforming to view coordinates

This discussion is connected to the gegl-developer-list.gnome.org mailing list which is provided by the GIMP developers and not related to gimpusers.com.

This is a read-only list on gimpusers.com so this discussion thread is read-only, too.

3 of 3 messages available
Toggle history

Please log in to manage your subscriptions.
[PATCH] Fix rect position when trasnforming to view coordinates Jordi Fita 26 May 11:11
  [PATCH] Fix rect position when trasnforming to view coordinates Michael Muré 29 May 05:08
  [PATCH] Fix rect position when trasnforming to view coordinates Jon Nordby 19 Jun 08:27
Jordi Fita
2012-05-26 11:11:32 UTC (over 12 years ago)

[PATCH] Fix rect position when trasnforming to view coordinates

Hello,

I sent attached to this letter a patch to view-helper's model_rect_to_view_rect() function that computes the position of view rectangle correctly--instead of subtracting the rectangle's coordinate from the scaled position, it subtracts the widget's position.

With this patch, gegl-gtk-paint works better.

Regards,

Jordi

Michael Muré
2012-05-29 05:08:01 UTC (over 12 years ago)

[PATCH] Fix rect position when trasnforming to view coordinates

Hi,

Please fill a bug and attach your patch to it. https://bugzilla.gnome.org/enter_bug.cgi?product=GEGL

Patch like this tend to get lost if nobody take care of them immediately.

Thank you.

2012/5/26 Jordi Fita

Hello,

I sent attached to this letter a patch to view-helper's model_rect_to_view_rect() function that computes the position of view rectangle correctly--instead of subtracting the rectangle's coordinate from the scaled position, it subtracts the widget's position.

With this patch, gegl-gtk-paint works better.

Regards,

Jordi

_______________________________________________ gegl-developer-list mailing list
gegl-developer-list@gnome.org
https://mail.gnome.org/mailman/listinfo/gegl-developer-list

Jon Nordby
2012-06-19 08:27:53 UTC (over 12 years ago)

[PATCH] Fix rect position when trasnforming to view coordinates

On 26 May 2012 13:11, Jordi Fita wrote:

Hello,

I sent attached to this letter a patch to view-helper's model_rect_to_view_rect() function that computes the position of view rectangle correctly--instead of subtracting the rectangle's coordinate from the scaled position, it subtracts the widget's position.

With this patch, gegl-gtk-paint works better.

Hi,

I've now applied the patch, and also added some tests for redraws with scaling+translations.

Thanks a lot for your contribution!

commit f3bce7aecaf408168b24cb460983f5dca326cda0 Author: Jordi Fita
Date: Sun May 6 13:28:54 2012 +0200

Fixed rect pos in model_rect_to_view_rect