Hi Partha

On Sun, Dec 18, 2011 at 12:15:37PM -0500, Partha Bagchi wrote:

Mukund,

You asked to bring missing prototype errors (here?). Anyway, win-snap and common both fail due to Werror-missing-prototypes.

ender also mentioned win32 build issues. I think he builds now after patching configure.ac to disable this for Windows builds.

Paste the win-snap compile log here.

What fails in plug-ins/common? Is it win32 specific code? Nothing in that dir fails to build on Linux. Paste the compile log for this too.

I can't directly support Windows, but I'll try to help in resolving it.

BTW, -Werror=missing-prototypes was introduced after discussion and I'm not going to remove it. We wasted time with bug reports against the last release on some distros which this compiler flag could've caught. The missing protos simply need to be added. Send the logs and we'll figure out what needs to be done.

Kind regards,

Mukund

On Sunday, December 18, 2011, 18:43:07, Mukund Sivaraman wrote:

What fails in plug-ins/common? Is it win32 specific code? Nothing in that dir fails to build on Linux. Paste the compile log for this too.

IIRC, only the jpeg plugin, due to lcms-related issues.

Hi guys,

I had to make these prototypes in order to build GIMP today, so I've just commited them.

On Sun, Dec 18, 2011 at 5:13 PM, Partha Bagchi wrote:

2011/12/18 Jernej Simončič :

On Sunday, December 18, 2011, 18:43:07, Mukund Sivaraman wrote:

What fails in plug-ins/common? Is it win32 specific code? Nothing in that dir fails to build on Linux. Paste the compile log for this too.

IIRC, only the jpeg plugin, due to lcms-related issues.

-- < Jernej Simončič ><><><><>< http://eternallybored.org/ >

There is an exception to all laws. -- Government's Law

_______________________________________________ gimp-developer-list mailing list
gimp-developer-list@gnome.org
http://mail.gnome.org/mailman/listinfo/gimp-developer-list

You are probably right. I did a distclean and re compiled and did not see an issue with common - so sorry about that.

As for win-snap, here is what I am getting:

winsnap.c: At top level: winsnap.c:397:1: error: no previous prototype for 'setCaptureType' [-Werror=missing-prototypes]
winsnap.c:642:1: error: no previous prototype for 'InitApplication' [-Werror=missing-prototypes]
winsnap.c:690:1: error: no previous prototype for 'InitInstance' [-Werror=missing-prototypes]
winsnap.c:717:1: error: no previous prototype for 'winsnapWinMain' [-Werror=missing-prototypes]
cc1.exe: some warnings being treated as errors

make[3]: *** [winsnap.o] Error 1 make[3]: Leaving directory
`/usr/src/gimp/gimp-2.7.5/gimp-2.7.5/plug-ins/win-snap' make[2]: *** [all-recursive] Error 1 make[2]: Leaving directory `/usr/src/gimp/gimp-2.7.5/gimp-2.7.5/plug-ins' make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory `/usr/src/gimp/gimp-2.7.5/gimp-2.7.5' make: *** [all] Error 2
_______________________________________________ gimp-developer-list mailing list
gimp-developer-list@gnome.org
http://mail.gnome.org/mailman/listinfo/gimp-developer-list