RSS/Atom feed Twitter
Site is read-only, email is disabled
  1. Chat
  2. Useful links
  3. Polls

Featured content

[PATCH] Fix for memory and file descriptor leaks

This discussion is connected to the gimp-developer-list.gnome.org mailing list which is provided by the GIMP developers and not related to gimpusers.com.

This is a read-only list on gimpusers.com so this discussion thread is read-only, too.

2 of 2 messages available
Toggle history

Please log in to manage your subscriptions.
[PATCH] Fix for memory and file descriptor leaks Nelson A. de Oliveira 09 Nov 18:20
  [PATCH] Fix for memory and file descriptor leaks Sven Neumann 12 Nov 20:58
Nelson A. de Oliveira
2010-11-09 18:20:12 UTC (about 14 years ago)

[PATCH] Fix for memory and file descriptor leaks

Hi!

Can somebody review two patches that (hopefully) fix some memory and file descriptor leaks, please?

The first one is basically g_free()s and fclose()s: http://people.debian.org/~naoliv/misc/gimp/patches/0001-Fix-memory-and-descriptor-leaks.patch

For the second one, instead including a fclose(fp) for every block with a "return FALSE;" in it I just moved it below (since it was not being used before).
http://people.debian.org/~naoliv/misc/gimp/patches/0002-Move-file-opening-block-to-after-some-tests.patch

Is there something wrong with them, please?

Thank you!

Best regards, Nelson

Sven Neumann
2010-11-12 20:58:00 UTC (about 14 years ago)

[PATCH] Fix for memory and file descriptor leaks

On Tue, 2010-11-09 at 16:20 -0200, Nelson A. de Oliveira wrote:

Can somebody review two patches that (hopefully) fix some memory and file descriptor leaks, please?

The first one is basically g_free()s and fclose()s: http://people.debian.org/~naoliv/misc/gimp/patches/0001-Fix-memory-and-descriptor-leaks.patch

For the second one, instead including a fclose(fp) for every block with a "return FALSE;" in it I just moved it below (since it was not being used before).
http://people.debian.org/~naoliv/misc/gimp/patches/0002-Move-file-opening-block-to-after-some-tests.patch

Is there something wrong with them, please?

I have pushed both patches to master. Thanks for your contribution.

Sven