On 09/06/2010 10:02 PM, Sven Neumann wrote:

On Mon, 2010-09-06 at 21:38 +0200, Martin Nordholts wrote:

On 09/06/2010 09:22 PM, Sven Neumann wrote:

Will buildbot build failures be posted to this list? Do you have the 'blame' feature setup so that the commits that potentially broke the build are listed?

I think posting failures to the list would create too much spam, my plan was to have an IRC bot for that instead.

Hmm, buildbot has support for that, but I don't quite understand what buildbot output on IRC would be good for. IMO the buildbot web-site should be accessible by anyone and the bot should send mails in the case of a build failure. Given how seldom the GIMP tree does not compile, this shouldn't create too much traffic.

Well, mails would not only be sent in case of compile failure but also in the case of make distcheck failure, which is quite easy to break. But we can certainly try and see how it plays out.

/ Martin

On 09/07/2010 06:26 PM, Emil Assarsson wrote:

Hi,

How about letting this buildbot approving commits in some way? http://wiki.hudson-ci.org/display/HUDSON/Gerrit+Plugin

My employer uses Hudson and I considered using Hudson for GIMP too. Automatically building and testing commits before they are merged to master is a really neat thing to do.

But I chose buildbot over Hudson because

* buildbot is more readily available than Hudson, for example, Fedora 13 does not have Hudson packages
* buildbot is built on Python, which is less controversial in terms of software freedom than Java (Personally I'm fine with both, but it can still matter to some)
* I already knew Hudson and wanted to learn buildbot * I feared that people would look at Gerrit+Hudson as an obstacle, since commits needs to be submitted, it's not enough to just push

And now that I've experimented with buildbot a bit, I have ended up liking the system, so I don't plan to switch over to Hudson

/ Martin

On 09/07/2010 07:56 AM, Martin Nordholts wrote:

On 09/06/2010 10:02 PM, Sven Neumann wrote:

On Mon, 2010-09-06 at 21:38 +0200, Martin Nordholts wrote:

On 09/06/2010 09:22 PM, Sven Neumann wrote:

Will buildbot build failures be posted to this list? Do you have the 'blame' feature setup so that the commits that potentially broke the build are listed?

I think posting failures to the list would create too much spam, my plan was to have an IRC bot for that instead.

Hmm, buildbot has support for that, but I don't quite understand what buildbot output on IRC would be good for. IMO the buildbot web-site should be accessible by anyone and the bot should send mails in the case of a build failure. Given how seldom the GIMP tree does not compile, this shouldn't create too much traffic.

Well, mails would not only be sent in case of compile failure but also in the case of make distcheck failure, which is quite easy to break. But we can certainly try and see how it plays out.

I have mails being sent on failure now to my own inbox, but the blamelist doesn't work yet. As soon as it does I'll make the buildbot (currently hosted on my laptop until we have a proper host) send mails directly to gimp-developer.

For now I'll just forward failure mails manually.

GIMP make distcheck failed tonight:

make[1]: Entering directory `/var/buildbot-slave/gimp/build'

Problem found in ./libgimp/gimp.def the following symbols are in the library, but are not listed in the .def-file: + gimp_item_transform_2d
+ gimp_item_transform_flip
+ gimp_item_transform_flip_simple + gimp_item_transform_matrix + gimp_item_transform_perspective + gimp_item_transform_rotate + gimp_item_transform_rotate_simple + gimp_item_transform_scale
+ gimp_item_transform_shear

*** .def files inconsistent *** make[1]: *** [check-defs] Error 1 make[1]: Leaving directory `/var/buildbot-slave/gimp/build' make: *** [distdir] Error 2

/ Martin