RSS/Atom feed Twitter
Site is read-only, email is disabled

Patch to improve the brush size keyboard shortcuts

This discussion is connected to the gimp-developer-list.gnome.org mailing list which is provided by the GIMP developers and not related to gimpusers.com.

This is a read-only list on gimpusers.com so this discussion thread is read-only, too.

4 of 4 messages available
Toggle history

Please log in to manage your subscriptions.

Patch to improve the brush size keyboard shortcuts Dieki N 26 May 03:05
  Patch to improve the brush size keyboard shortcuts Dieki N 26 May 03:06
   Patch to improve the brush size keyboard shortcuts Owen 27 May 01:13
  Patch to improve the brush size keyboard shortcuts Martin Nordholts 26 May 17:05
Dieki N
2010-05-26 03:05:37 UTC (over 14 years ago)

Patch to improve the brush size keyboard shortcuts

I've created a patch to improve the behavior of brush size increase\decrease keyboard shortcuts, particularly at small sizes and large sizes. The old behavior increased\decreased the brush size by a fixed value (0.10), which worked fine at medium sizes, and reasonably well at large sizes (since you could hold down the keyboard shortcut to get a lot of change), but completely broke down at sizes underneath 0.20, since you tended to have two options; too big or too small. (Or, when under 0.10, none at all!)

This patch sets the increment according to the following rules:

If is greater than 2, it increments by 0.20. If is less than 2 but greater than 0.50, it increments by 0.10. If is less than 0.50 but greater than 0.10, it increments by 0.05.
If is less than 0.10, it increments by 0.01.

I've tested this in my own use over the last couple weeks, and it seems most helpful, particularly when masking fine details. This patch is against Master.

Dieki

Dieki N
2010-05-26 03:06:48 UTC (over 14 years ago)

Patch to improve the brush size keyboard shortcuts

On Tue, May 25, 2010 at 8:05 PM, Dieki N wrote:

I've created a patch to improve the behavior of brush size increase\decrease keyboard shortcuts, particularly at small sizes and large sizes. The old behavior increased\decreased the brush size by a fixed value (0.10), which worked fine at medium sizes, and reasonably well at large sizes (since you could hold down the keyboard shortcut to get a lot of change), but completely broke down at sizes underneath 0.20, since you tended to have two options; too big or too small. (Or, when under 0.10, none at all!)

This patch sets the increment according to the following rules:

If is greater than 2, it increments by 0.20. If is less than 2 but greater than 0.50, it increments by 0.10.
If is less than 0.50 but greater than 0.10, it increments by 0.05.
If is less than 0.10, it increments by 0.01.

I've tested this in my own use over the last couple weeks, and it seems most helpful, particularly when masking fine details. This patch is against Master.

Dieki

Maybe it would help if I actually attached the patch. :) Here it is.

Martin Nordholts
2010-05-26 17:05:29 UTC (over 14 years ago)

Patch to improve the brush size keyboard shortcuts

On 05/26/2010 03:05 AM, Dieki N wrote:

I've created a patch to improve the behavior of brush size increase\decrease keyboard shortcuts, particularly at small sizes and large sizes.

Just checking: Have you tried the 'Increase/Decreate Radius Relative' keyboard shortcuts?

/ Martin

Owen
2010-05-27 01:13:23 UTC (over 14 years ago)

Patch to improve the brush size keyboard shortcuts

On Tue, 25 May 2010 20:06:48 -0500 Dieki N wrote:

On Tue, May 25, 2010 at 8:05 PM, Dieki N wrote:

I've created a patch to improve the behavior of brush size increase\decrease keyboard shortcuts, particularly at small sizes and large sizes. The old behavior increased\decreased the brush size by a fixed value (0.10), which worked fine at medium sizes, and reasonably well at large sizes (since you could hold down the keyboard shortcut to get a lot of change), but completely broke down at sizes underneath 0.20, since you tended to have two options; too big or too small. (Or, when under 0.10, none at all!)

This patch sets the increment according to the following rules:

If is greater than 2, it increments by 0.20. If is less than 2 but greater than 0.50, it increments by 0.10.
If is less than 0.50 but greater than 0.10, it increments by 0.05.
If is less than 0.10, it increments by 0.01.

I've tested this in my own use over the last couple weeks, and it seems most helpful, particularly when masking fine details. This patch is against Master.

Well I tried that patch and like it. I also thought that the scaling was too aggressive and that patch seems to settle it down nicely.

Thanks

Owen