Hello lloyd,

On Wed, May 19, 2010 at 5:03 PM, lloyd konneker wrote:

The Resynthesizer package includes: the engine written in C++, with its own GUI of settings several plugins written in Scheme that call the engine: Smart enlarge
Smart remove selection (now called "Heal selection")

I don'nt believe the developers will accept it since it's written in C++. I would be happy to see this plugin as a part of GIMP, but believe that it will have to be re-written in C (if you need objects, use GObject instead which is the the object library for C that gimp uses) in order for it to be included.

There is nothing against including new plugins. Hoever, the fact that it's in C++ (and the fact that it's not in the gnu coding style - although this is minor) will make it hard to maintain for people who don't know C++.
I just gave a look at the source - it's not too big (only 980 lines and less than half of them are the algorithm) and the usage of C++ is very minor. It shouldn't be too hard to port the plugin to C (al least, this is the impression I got).

I would really like to see resynthesizer included with GIMP - I do hope it will be accepted, even if it will require a bit of rewriting some small parts of the code.

~LightningIsMyName

On Wed, May 19, 2010 at 6:34 PM, LightningIsMyName wrote:

Hoever, the fact that it's in C++ (and the fact that it's not in the gnu coding style - although this is minor) will make it hard to maintain for people who don't know C++.

Hasn't Lloyd offered his services to _maintain_?

Alexandre

Hello,

On Wed, May 19, 2010 at 5:54 PM, Alexandre Prokoudine wrote:

On Wed, May 19, 2010 at 6:34 PM, LightningIsMyName wrote:

Hoever, the fact that it's in C++ (and the fact that it's not in the gnu coding style - although this is minor) will make it hard to maintain for people who don't know C++.

Hasn't Lloyd offered his services to _maintain_?

He did, but he also expressed some hope that it won't need to be re-coded:

On Wed, May 19, 2010 at 5:03 PM, lloyd konneker wrote:

But not recode to Gimp style?

I should have made my point more clear - sorry about that...

~LightningIsMyName

Thats a great idea.

I regularly use this plug-in and also teach others how to use it. Its VERY useful when creating textures for 3d graphics. Today is only easy to install on Linux: on windows and MAC is a pain to get it working.

Please take this into consideration before refusing.

Thanks.

2010/5/19 LightningIsMyName

Hello,

On Wed, May 19, 2010 at 5:54 PM, Alexandre Prokoudine wrote:

On Wed, May 19, 2010 at 6:34 PM, LightningIsMyName wrote:

Hoever, the fact that it's in C++ (and the fact that it's not in the gnu coding style - although this is minor) will make it hard to maintain for people who don't know C++.

Hasn't Lloyd offered his services to _maintain_?

He did, but he also expressed some hope that it won't need to be re-coded:

On Wed, May 19, 2010 at 5:03 PM, lloyd konneker wrote:

But not recode to Gimp style?

I should have made my point more clear - sorry about that...

~LightningIsMyName _______________________________________________ Gimp-developer mailing list
Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer

Regardless of in or out, the binary and scripts need to work together. On Windows there are two binaries floating around that have a different number of parameters that may break scripts asuming the other binary.

-Rob A>

On 5/19/10, Filipe Soares Dilly wrote:

Thats a great idea.

I regularly use this plug-in and also teach others how to use it. Its VERY useful when creating textures for 3d graphics. Today is only easy to install on Linux: on windows and MAC is a pain to get it working.

Please take this into consideration before refusing.

Thanks.

2010/5/19 LightningIsMyName

Hello,

On Wed, May 19, 2010 at 5:54 PM, Alexandre Prokoudine wrote:

On Wed, May 19, 2010 at 6:34 PM, LightningIsMyName wrote:

Hoever, the fact that it's in C++ (and the fact that it's not in the gnu
coding style - although this is minor) will make it hard to maintain for people who don't know C++.

Hasn't Lloyd offered his services to _maintain_?

He did, but he also expressed some hope that it won't need to be re-coded:

On Wed, May 19, 2010 at 5:03 PM, lloyd konneker wrote:

But not recode to Gimp style?

I should have made my point more clear - sorry about that...

~LightningIsMyName _______________________________________________ Gimp-developer mailing list
Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer

--
Filipe Soares Dilly
dilly.carbonmade.com/

I regularly use this plug-in and also teach others how to use it. Its VERY useful when creating textures for 3d graphics. Today is only easy to install on Linux: on windows and MAC is a pain to get it working.

The Mac OS X distribution is already shipping this plug-in by default.

-skl

On Wed, 2010-05-19 at 10:03 -0400, lloyd konneker wrote:

This is a request to put the Resynthesizer plugin in the Gimp project.

The author, Paul Harrison, has given me permission to maintain Resynthesizer.

Well, if you maintain the plug-in, that is very good. We really don't have enough resources to maintain more plug-ins in the GIMP tree. We would love to see even more plug-ins maintained outside the GIMP source tree.

What would be the benefit for you and the core GIMP developers (and the users of course), if the plug-in was maintained in the GIMP source tree?

Sven

On 05/19/2010 04:03 PM, lloyd konneker wrote:

This is a request to put the Resynthesizer plugin in the Gimp project.

The author, Paul Harrison, has given me permission to maintain Resynthesizer.

I am an unaffiliated computer scientist and have developed in C, Python, and Scheme under Unix, Linux, and MS Windows.

I have studied the Resynthesizer code and created a short list of bug fixes, performance enhancements, and refactorings (breaking one large source file into many, and splitting the resynthesizer into an engine and a GUI.)

If that's agreeable, I will learn Gimp development processes and create the proper make files etc before uploading a new version to the Gimp project. Also, internationalize where necessary. (But not recode to Gimp style?)

The Resynthesizer package includes: the engine written in C++, with its own GUI of settings several plugins written in Scheme that call the engine: Smart enlarge
Smart remove selection (now called "Heal selection")

I would like to include plugins that call the resynthesizer, by other authors:
Uncrop - synthesizes a larger image, same perspective, wider view. Written by me.
Fill resynthesized pattern - fills with a pattern, but a random texture instead of a regular tiling. Written by Rob A

Currently the resynthesizer package is distributed by Debian and other organizations. I have corresponded with the Debian builder of resynthesizer, but he is not the maintainer and relies on the author's downstream source.

I believe it is one of the most useful and popular plugin packages. Putting it in Gimp and getting the bugs fixed would help many users.

I would be glad to provide more details.

Hi Lloyd,

Personally I'm not principally against including Resynthesizer, but for it to happen it is important that the initial set of patches looks good. So I suggest you start with getting together patches that adds Resynthesizer to GIMP which can then be evaluated.

I certainly see it as a favour for users to include a popular plug-in in the default install.

/ Martin

El Miércoles, 19 de Mayo de 2010 16:03:23 lloyd konneker escribió:

This is a request to put the Resynthesizer plugin in the Gimp project.

I vote for that!

I'm a Gimp teacher. I have teach very people and Resynthesizer makes all the people goes crazy!

You could explain people lot of nice tools Gimp includes... people says: ok, this is very nice, but when I use Photoshop...
But when you show people Resynthesizer plugin working, people says: Wow!!! I Want it! How I can install Gimp on my computer now?

Then, when you explain people, that Resynthesizer must be downloaded, copied, configured... installed as a plugin... bla, bla, bla... people says: Ah! well! if someday I need the Gimp, I will ask you for installing it... then, they gone...

I know Gimp is great, and complex, there are no much resources and to add more complexity is a no good idea, but Gimp is a great application, and lot of people will love it if they discover it, if they can learn it.

But if we want people discover Gimp, and use Gimp, Gimp must have some "WOW" features. Features that cause a great impact on people.... Resynthesizer is a "WOW" feature who impacts on people and leave in the people's mind the idea that Gimp is a great and valuable software.

When more people will discover Gimp, more people will install it, and more people like me will appear to teach this people how to use Gimp... and I think more resources will come to Gimp...

I know it is a difficult decission to include this and others features, but I think you must consider the "impact" of some features can cause on users. I think more users is good for every software, and all actions that gain more users for the Gimp is a good action. For this reason I publish my Gimp Howtos and tutorials, I teach people to use Gimp (workshops and courses) and I vote for include some relevant features like Resynthesizer on Gimp.

I hope you consider these things before make a decission. ;)

Great work and thanks for bring us this excelent software. ;)

Salu2 de jEsuSdA 8)