RSS/Atom feed Twitter
Site is read-only, email is disabled
  1. Chat
  2. Useful links
  3. Polls

Featured content

Gimp undo-redo tree

This discussion is connected to the gimp-developer-list.gnome.org mailing list which is provided by the GIMP developers and not related to gimpusers.com.

This is a read-only list on gimpusers.com so this discussion thread is read-only, too.

2 of 2 messages available
Toggle history

Please log in to manage your subscriptions.
Gimp undo-redo tree Jan Rüegg 19 Sep 14:12
  Gimp undo-redo tree Martin Nordholts 19 Sep 14:40
Jan Rüegg
2009-09-19 14:12:50 UTC (over 15 years ago)

Gimp undo-redo tree

Hello, I am new to gimp development, and I'm trying to implement an undo - redo tree in Gimp

Something like this: http://gimp-brainstorm.blogspot.com/2008/07/undoredo-tree.html

but I have some problems understanding "app/widgets/gimpcontainerview.c" and "app/widgets/gimpcontainertreeview.c"

Is anyone interested in helping me? http://up.mibbit.com/up/lXpwQN2h.diff is what I've got so far. Just to give you an idea to what I would like to achieve...

usage: -patch against latest git
- open a new image and do some brush strokes, watch the undo history - click on some of the items in there and see what happens - click the THIRD (hardcoded at the moment) picture from the top of the undo history
- do some other strokes
what should happen:
a treelike structure will be shown, and you can flip open and closed the new tree branch, and go backwards and forwards in the undo history there

Cheers Jan

Martin Nordholts
2009-09-19 14:40:38 UTC (over 15 years ago)

Gimp undo-redo tree

On 09/19/2009 02:12 PM, Jan Rüegg wrote:

Hello, I am new to gimp development, and I'm trying to implement an undo - redo tree in Gimp

Hi Jan and welcome!

I'd love to help you out hacking on GIMP. My preferred way to do tight collaboration is using IRC. In GIMP's case that's #gimp on irc.gnome.org.

Regarding the patch, it is very hackish at the moment. For the real stuff you'd need to introduce new abstractions and concepts, otherwise the implementation will become a hack. But it's a start!

Also, patches should be generated with

git format-patch origin/master

instead of git-diff. And when distributing patches from web servers it is good to use the .txt extension so that the patch can easily be shown within the browser. Often there is no MIME type association for .patch or .diff.

Best regards,
Martin