RSS/Atom feed Twitter
Site is read-only, email is disabled

Do we need different window hints for the docks and the toolbox?

This discussion is connected to the gimp-developer-list.gnome.org mailing list which is provided by the GIMP developers and not related to gimpusers.com.

This is a read-only list on gimpusers.com so this discussion thread is read-only, too.

3 of 3 messages available
Toggle history

Please log in to manage your subscriptions.

Do we need different window hints for the docks and the toolbox? Martin Nordholts 09 Sep 19:07
  Do we need different window hints for the docks and the toolbox? Martin Nordholts 09 Sep 22:53
   Do we need different window hints for the docks and the toolbox? Martin Nordholts 10 Sep 00:06
Martin Nordholts
2009-09-09 19:07:28 UTC (about 15 years ago)

Do we need different window hints for the docks and the toolbox?

Hi,

In Edit->Preferences->Window Management you can set the window hint on the toolbox and the docks separately. Do we really need this kind of granularity? Isn't it enough to only have one window hint setting and use that for both the toolbox and the docks? I can't come up with a use case where two different hints are necessary. If we can use a single hint option than both the preference UI and the code can be simplified.

The commit [1] that introduced the hint concept doesn't explain why two separate options were added. Do you remember your reasons for doing this Sven?

Regards,
Martin

[1] commit 5a43e55c507ba505c3f0e3602bf82bbc06834ae3 Author: Sven Neumann
Date: Thu Nov 20 20:36:55 2003 +0000

Martin Nordholts
2009-09-09 22:53:41 UTC (about 15 years ago)

Do we need different window hints for the docks and the toolbox?

On 09/09/2009 07:10 PM, Martin Nordholts wrote:

The commit [1] that introduced the hint concept doesn't explain why two separate options were added. Do you remember your reasons for doing this Sven?

Drc reminded me of that once upon a time the toolbox was the main window. Since that is not the case any longer, let's get rid of the toolbox specific hint and use the dock hint also for the toolbox.

/ Martin

Martin Nordholts
2009-09-10 00:06:10 UTC (about 15 years ago)

Do we need different window hints for the docks and the toolbox?

On 09/09/2009 10:56 PM, Martin Nordholts wrote:

Drc reminded me of that once upon a time the toolbox was the main window. Since that is not the case any longer, let's get rid of the toolbox specific hint and use the dock hint also for the toolbox.

I've done this now:

commit e1faf82e7d9a9dd31c5e7e88abc45c92b3cc603b Author: Martin Nordholts
Date: Wed Sep 9 23:34:18 2009 +0200

Get rid of toolbox-window-hint, use dock-window-hint instead

Since the toolbox no longer is the main window with a menu, use the same hint for the toolbox (which actually is a dock) as for the other docks.

/ Martin