Do I need a github account?
This discussion is connected to the gimp-docs-list.gnome.org mailing list which is provided by the GIMP developers and not related to gimpusers.com.
This is a read-only list on gimpusers.com so this discussion thread is read-only, too.
| Do I need a github account? | Andrew Douglas Pitonyak | 25 Jun 02:26 |
| Do I need a github account? | Roman Joost | 25 Jun 10:04 |
| Do I need a github account? | Andrew Douglas Pitonyak | 25 Jun 14:44 |
| Do I need a github account? | Roman Joost | 25 Jun 15:04 |
| Do I need a github account? | Andrew Douglas Pitonyak | 26 Jun 00:06 |
| Do I need a github account? | Sven Neumann | 25 Jun 11:59 |
Do I need a github account?
I managed to modify the GIMP documentation including a build, so I know that it works.
I desire to create a patch to that I can provide it to Mr. Joost.
At this point, things are becoming a wee bit confusing.
Here is what I have done so far:
Commit my changed file
$ git commit -a $ git format-patch HEAD^
From what I glean from some web pages, it seems that I need to use github to send my changes for review. OK, so I created an account and even a public repo that I named "andy-gimp-help-2".
My best guess is that I now submit using:
$ git remote add github git@github.com:pitonyak/andy-gimp-help-2.git $ git push github master
I am hesitant to use such commands and then possibly create an entire copy of the gimp documentation, when all I think that I need to do is figure out how to submit a patch for review so that no one needs to manually enter my changes.
Do I need a github account?
Hi Andrew,
On Wed, Jun 24, 2009 at 08:26:02PM -0400, Andrew Douglas Pitonyak wrote:
I managed to modify the GIMP documentation including a build, so I know that it works.
I desire to create a patch to that I can provide it to Mr. Joost.
At this point, things are becoming a wee bit confusing.
Here is what I have done so far:
Commit my changed file
$ git commit -a $ git format-patch HEAD^
Looks all good to me.
From what I glean from some web pages, it seems that I need to use github to send my changes for review. OK, so I created an account and even a public repo that I named "andy-gimp-help-2".
My best guess is that I now submit using:
$ git remote add github git@github.com:pitonyak/andy-gimp-help-2.git $ git push github master
No - please don't do that. That would confuse everyone, because then two repositories exist where people can contribute to. I actually urge you remove that project from github.
I am hesitant to use such commands and then possibly create an entire copy of the gimp documentation, when all I think that I need to do is figure out how to submit a patch for review so that no one needs to manually enter my changes.
Just send your patches to me and I'll have a look at it.
What you could also do is, put the patches on a webserver somewhere, write an email to the mailinglist and put a link to your patches in it. Ask if someone could review your patches.
Cheers,
Do I need a github account?
Hi,
On Wed, 2009-06-24 at 20:26 -0400, Andrew Douglas Pitonyak wrote:
$ git commit -a
$ git format-patch HEAD^
The output of this command will be a nicely formatted patch that you can send to Roman for review. He can easily apply your changes to his tree using the 'git am' command. So don't worry, no one needs to manually enter your changes.
Sven
Do I need a github account?
I expected that it was something like this....
Well, now that I have created the patch, I have no idea how to "extract the patch as a file" so that I can host it or send it.
After work tonight, I will look for the command that tells me how to extract the "patch" as a listing (that I can redirect) or as a file. The changes are, after-all, small and simple for my first try.
On 06/25/2009 04:04 AM, Roman Joost wrote:
Hi Andrew,
On Wed, Jun 24, 2009 at 08:26:02PM -0400, Andrew Douglas Pitonyak wrote:
I managed to modify the GIMP documentation including a build, so I know that it works.
I desire to create a patch to that I can provide it to Mr. Joost.
At this point, things are becoming a wee bit confusing.
Here is what I have done so far:
Commit my changed file
$ git commit -a $ git format-patch HEAD^
Looks all good to me.
From what I glean from some web pages, it seems that I need to use github to send my changes for review. OK, so I created an account and even a public repo that I named "andy-gimp-help-2".
My best guess is that I now submit using:
$ git remote add github git@github.com:pitonyak/andy-gimp-help-2.git $ git push github master
No - please don't do that. That would confuse everyone, because then two repositories exist where people can contribute to. I actually urge you remove that project from github.
I am hesitant to use such commands and then possibly create an entire copy of the gimp documentation, when all I think that I need to do is figure out how to submit a patch for review so that no one needs to manually enter my changes.
Just send your patches to me and I'll have a look at it.
What you could also do is, put the patches on a webserver somewhere, write an email to the mailinglist and put a link to your patches in it. Ask if someone could review your patches.
Cheers,
Do I need a github account?
On Thu, Jun 25, 2009 at 08:44:22AM -0400, Andrew Douglas Pitonyak wrote:
I expected that it was something like this....
Well, now that I have created the patch, I have no idea how to "extract the patch as a file" so that I can host it or send it.
After work tonight, I will look for the command that tells me how to extract the "patch" as a listing (that I can redirect) or as a file. The changes are, after-all, small and simple for my first try.
Easy as pie:
git format-patch
If you don't get a patch, you probably haven't commited your changes locally:
git commit -a
Cheers,
Do I need a github account?
On 06/25/2009 09:04 AM, Roman Joost wrote:
On Thu, Jun 25, 2009 at 08:44:22AM -0400, Andrew Douglas Pitonyak wrote:
I expected that it was something like this....
Well, now that I have created the patch, I have no idea how to "extract the patch as a file" so that I can host it or send it.
After work tonight, I will look for the command that tells me how to extract the "patch" as a listing (that I can redirect) or as a file. The changes are, after-all, small and simple for my first try.
Easy as pie:
git format-patch
If you don't get a patch, you probably haven't commited your changes locally:
git commit -a
Cheers,
Oh, I see, it appeared to do nothing because it saved the output to a file.... Very nice. Roman, you should now have the patch.
