RSS/Atom feed Twitter
Site is read-only, email is disabled

bogus floating selection code?

This discussion is connected to the gimp-developer-list.gnome.org mailing list which is provided by the GIMP developers and not related to gimpusers.com.

This is a read-only list on gimpusers.com so this discussion thread is read-only, too.

5 of 5 messages available
Toggle history

Please log in to manage your subscriptions.

bogus floating selection code? David Gowers 13 Feb 06:11
  bogus floating selection code? peter sikking 13 Feb 09:34
   bogus floating selection code? Michael Natterer 13 Feb 09:58
    bogus floating selection code? Alexandre Prokoudine 13 Feb 16:32
  bogus floating selection code? Michael Natterer 13 Feb 16:36
David Gowers
2009-02-13 06:11:24 UTC (almost 16 years ago)

bogus floating selection code?

I had just pasted a piece of image (copied from a layer without alpha, pasted back on to a layer without alpha) and, as I clicked to anchor it, GIMP crashed with this message:

ERROR:gegl-node.c:1929:gegl_node_remove_child: assertion failed: (child_priv->parent == self || child_priv->parent == NULL)

I'm guessing this is a fairly simple mistake, so I posted here (mainly for Mitch's benefit). It's difficult to reproduce, though. I had only used pencil (with 1px brush) and bucketfill (threshold = 0) before the crash occurred.

David

peter sikking
2009-02-13 09:34:24 UTC (almost 16 years ago)

bogus floating selection code?

David Gowers wrote:

I had just pasted a piece of image (copied from a layer without alpha, pasted back on to a layer without alpha) and, as I clicked to anchor it, GIMP crashed with this message:

ERROR:gegl-node.c:1929:gegl_node_remove_child: assertion failed: (child_priv->parent == self || child_priv->parent == NULL)

I'm guessing this is a fairly simple mistake, so I posted here (mainly for Mitch's benefit). It's difficult to reproduce, though. I had only used pencil (with 1px brush) and bucketfill (threshold = 0) before the crash occurred.

or a lot of layer (mask) create. I can consistently crash svn GIMP on this, but not fresh put of the box.

--ps

founder + principal interaction architect man + machine interface works

http://mmiworks.net/blog : on interaction architecture

Michael Natterer
2009-02-13 09:58:59 UTC (almost 16 years ago)

bogus floating selection code?

On Fri, 2009-02-13 at 09:34 +0100, peter sikking wrote:

David Gowers wrote:

I had just pasted a piece of image (copied from a layer without alpha, pasted back on to a layer without alpha) and, as I clicked to anchor it, GIMP crashed with this message:

ERROR:gegl-node.c:1929:gegl_node_remove_child: assertion failed: (child_priv->parent == self || child_priv->parent == NULL)

I'm guessing this is a fairly simple mistake, so I posted here (mainly for Mitch's benefit). It's difficult to reproduce, though. I had only used pencil (with 1px brush) and bucketfill (threshold = 0) before the crash occurred.

I can't reproduce this at all.

or a lot of layer (mask) create. I can consistently crash svn GIMP on this, but not fresh put of the box.

And I don't understand this at all ;)

ciao, --mitch

Alexandre Prokoudine
2009-02-13 16:32:42 UTC (almost 16 years ago)

bogus floating selection code?

On Fri, Feb 13, 2009 at 11:58 AM, Michael Natterer wrote:

I'm guessing this is a fairly simple mistake, so I posted here (mainly for Mitch's benefit). It's difficult to reproduce, though. I had only used pencil (with 1px brush) and bucketfill (threshold = 0) before the crash occurred.

I can't reproduce this at all.

Here is related reproducible crash sequence:

1. Open an image without alpha-channel 2. Ctrl+A, Ctrl+V
3. Ctrl+Shift+N to put the FS to a new layer 4. Repeat steps 2 and 3
5. GIMP crashes

That drove me nuts few days ago :)

Alexandre

Michael Natterer
2009-02-13 16:36:58 UTC (almost 16 years ago)

bogus floating selection code?

On Fri, 2009-02-13 at 15:41 +1030, David Gowers wrote:

I had just pasted a piece of image (copied from a layer without alpha, pasted back on to a layer without alpha) and, as I clicked to anchor it, GIMP crashed with this message:

ERROR:gegl-node.c:1929:gegl_node_remove_child: assertion failed: (child_priv->parent == self || child_priv->parent == NULL)

I'm guessing this is a fairly simple mistake, so I posted here (mainly for Mitch's benefit). It's difficult to reproduce, though. I had only used pencil (with 1px brush) and bucketfill (threshold = 0) before the crash occurred.

I was able to reproduce it and fixed it.

Thanks for spotting --mitch

2009-02-13 Michael Natterer

* app/core/gimpdrawable.c (gimp_drawable_sync_source_node): need to rip the floating selection's source node out of its layer's graph before using it in the floating selection sub-graph, and need to plug it back there when it's not a floating selection any longer.

Unrelated:

Also introduce a "fs_crop_node" that makes sure the floating selection stops at the drawable's boundaries.

(gimp_drawable_visibility_changed): use item->node instead of gimp_item_get_node() because the latter creates the node on demand.

* app/core/gimpdrawable-private.h: add fs_crop_node member.