Hi!
I'm writing X11 Mouse Cursor plug-in which enable GIMP to import and export a Xcursor file.
Current release is here.
http://registry.gimp.org/node/10764

I have implemented almost everything which I think is necessary and it is ready for being merged in GIMP itself. So, if I write a patch to include this plug-in in the svn tree of GIMP and throw it to bugzilla, will you accept it?

Hi, Martin.

If the patch is of high quality, I don't see why we would reject it.

OK, I will do my best.

Let me ask one more question.

My plug-in is currently depends on libXcursor. I think this will make it messy to build for Windows. (But I have no idea about it because I have never compiled any binary for Windows.) If I steel handleds of lines of code from the source of libXcursor, I will be able to remove that dependency. On the other hand, We will need to update the stolen code when libXcursor is updated in the future. Therefore, to steel, or not to steel: that is the question. Which is easy to maintain?

tks

Hi, sorry for my late replay.

Martin Nordholts wrote:

Without doubt we shall not steal because just as you say that would require us to update the plug-in whenever the lib updates.

Instead, your patch should add a test for libXcursor to configure.in, in the same manner as we test for a lot of other optional libs. Then in the Makefile.am you would test if libXcursor was found, and only build if it was found.

I did not think of not building!

Some keywords to google for:
Autoconf, Automake

Some files to look in: http://svn.gnome.org/viewvc/gimp/trunk/configure.in?view=markup And the various Makefile.am:s under the plug-ins directory.

I appreciate your kindly teaching. It was well worth to ask here.

- tks