Hi,

despite I didn't have a closer look to the patch I'm in doubt that the risk of that patch weights out the benefits.

potential benefits: - faster building if conversion is enabled. -> does the conversion work at all? AFAIK at least for german the converted screenshots look terrible
- less hd space used

potential risks: - image linking is in no way limited to one language in the docbook sources -> e.g. are images that are missing for a certain language are usually replaced by the same image in another language.

btw. are the installations of gimp-docs usually done for specific languages anyways? Do the installers of the usual suspects respect the user language at all?

Greetings, lexA

Am 21.01.2007 um 16:36 schrieb Peter Volkov (pva):

Hello.

Currently gimp-doc does not use ALL_LINGUAS during images installation and thus installs all images even if ALL_LINGUAS was set only to en. This increases building time if configured with --enable-convert as more
pictures requires Converting and also this increase disk usage of installed documentation. Suggested fix for the problem in attachment (patch against Makefile.am). Can anybody review and if this is correct fix apply it in your cvs?

If this mailing list is wrong place to report bugs, I'm sorry in advance... I have not found better place. Please, point me to the right
one.

In any way thank you for your time, Peter.

Hi Peter,

On Sun, Jan 21, 2007 at 06:36:51PM +0300, Peter Volkov (pva) wrote:

Currently gimp-doc does not use ALL_LINGUAS during images installation and thus installs all images even if ALL_LINGUAS was set only to en. This increases building time if configured with --enable-convert as more pictures requires Converting and also this increase disk usage of installed documentation. Suggested fix for the problem in attachment (patch against Makefile.am). Can anybody review and if this is correct fix apply it in your cvs?

I tried your patch today. Thanks a bunch, it's a good start. The current problem is -- like Axel already mentioned -- other languages are using images from English.
If you create the HTML files for only one language (e.g Russian or German) than you won't see most of the images.

There are two possibilities to solve this:

1) We leave the patch as it is and change the directory structure (put every common used image in a 'common' directory for example)
2) You have to modify your patch and add a fallback, so the patch includes *some* English screenshots.

I would really like to see the second idea happen. What do you think? Would you be able to do this?
If this issue is fixed, we can also provide prebuilt HTML tarballs for each release. So, you would solve a big task here :)

Btw. a god place to paste a new patch would be bugzilla. File a bug against GIMP (Help component), and put your patches there. We don't have an own module in bugzilla, yet.

Greetings,

Hi,

On Wed, 2007-01-24 at 13:05 +0100, Roman Joost wrote:

I tried your patch today. Thanks a bunch, it's a good start. The current problem is -- like Axel already mentioned -- other languages are using images from English.
If you create the HTML files for only one language (e.g Russian or German) than you won't see most of the images.

Since the GIMP help browser uses English as the default fallback language it seems to make sense to ensure that the english manual is always installed.

Btw. a god place to paste a new patch would be bugzilla. File a bug against GIMP (Help component), and put your patches there. We don't have an own module in bugzilla, yet.

Why isn't there a gimp-help product yet? Did you get any response to your request for it?

Sven

Hi Sven, Hey Peter,

On Wed, Jan 24, 2007 at 08:02:28PM +0100, Sven Neumann wrote:

On Wed, 2007-01-24 at 13:05 +0100, Roman Joost wrote:

I tried your patch today. Thanks a bunch, it's a good start. The current problem is -- like Axel already mentioned -- other languages are using images from English.
If you create the HTML files for only one language (e.g Russian or German) than you won't see most of the images.

Since the GIMP help browser uses English as the default fallback language it seems to make sense to ensure that the english manual is always installed.

Right - it's working for me as well and it'll go into our repository then.

Btw. a god place to paste a new patch would be bugzilla. File a bug against GIMP (Help component), and put your patches there. We don't have an own module in bugzilla, yet.

Why isn't there a gimp-help product yet? Did you get any response to your request for it?

Yep - last response was from Elijah Newren (#396142). I'll wait untill beginning of February and ask again what happened.

Greetings,

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1

Hi all,

Am 25.01.2007 um 08:54 schrieb Roman Joost:

Hi Sven, Hey Peter,

On Wed, Jan 24, 2007 at 08:02:28PM +0100, Sven Neumann wrote:

On Wed, 2007-01-24 at 13:05 +0100, Roman Joost wrote:

I tried your patch today. Thanks a bunch, it's a good start. The current
problem is -- like Axel already mentioned -- other languages are using
images from English.
If you create the HTML files for only one language (e.g Russian or German) than you won't see most of the images.

Since the GIMP help browser uses English as the default fallback language it seems to make sense to ensure that the english manual is always installed.

Right - it's working for me as well and it'll go into our repository then.

argh - that patch does not work. I just applied it and did a complete rebuild for de only[1].
First problem is "find: -wholename: unknown expression primary", obviously the -wholename parameter does not exist on the OS X version of find?!
As a result (?) all(!) images are missing in the html version. I guess we need to review this urgently.

Greetings, lexA

[1]: axel-wernickes-computer:~/Documents/Projekte/gimp-help-2 axelwernicke $ make ALL_LINGUAS="de"
mkdir -p -- html/de
mkdir -p -- pdf/de
*** Creating directories ***
Language: de
find: -wholename: unknown expression primary mkdir -p -- xml
- -- Profiling XML for de
- -- Validating XML for de number of errors: 0 *** Validating profiled XML ***
Log files of the validation process have been generated in the xml directory.
Please correct any errors before writing new content. *** Copying images ***
Language: de
find: -wholename: unknown expression primary *** Copying stylesheets ***
- -- Building HTML for de
Writing gimp-xrefs.xml for book(gimp-main) Writing pr01.html for preface
Writing ch01s02s02.html for sect2
Writing ch01s02s03.html for sect2

- --- Remember: There are only two tools in life. WD-40, for when something doesn't move, and should, and Duct Tape, for when something is moving and it shouldn't.
So does the universe explode if you spray duct tape with WD-40?

-----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (Darwin)

iD8DBQFFuR0eR9mXLVsAbiQRAugwAKDh/ibq73zi0zsja3IbiZEO7YN/pACdHWzE XOrh35d3jspElNOzzqTJjaQ=
=AfoW
-----END PGP SIGNATURE-----

----- Original Message ---

On Fri, Jan 26, 2007 at 07:59:05PM +0100, KolbjXrn StuestXl wrote:

argh - that patch does not work. I just applied it and did a complete rebuild for de only[1].
First problem is "find: -wholename: unknown expression primary", obviously the -wholename parameter does not exist on the OS X version of find?!

Well does or does it not exist on the Mac OS X platform?

I find the following description in the find manpage:

*wholename* pattern File name matches shell pattern pattern. The metacharacters do not treat `/' or `.' specially; so, for example, find . -wholename './sr*sc' will print an entry for a directory called './src/misc' (if one exists). To ignore a whole directory tree, use -prune rather than checking every file in the tree. For example, to skip the directory `src/emacs' and all files and directories under it, and print the names of the other files found, do something like this:
find . -wholename './src/emacs' -prune -o -print

As a result (?) all(!) images are missing in the html version. I guess we need to review this urgently.

As I tried with my built, don't do it for one language only. All translations are using English based images. As Sven stated, it makes also sense to install English as a fallback language.

It doesn't work for me either.

But of more importance to me:

I get no error messages about the missing image files. I had to look through the html files to find them.

Why not put all the 'en' images in an 'en' folder leaving the common images in the root in each folder? It would then be necessary to copy only the common images + lang specific images (folders). Perhaps there is other problems using this solution?

Hm.. no - see the solution above.

Greetings,

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1

- -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1

Am 26.01.2007 um 21:39 schrieb Roman Joost:

On Fri, Jan 26, 2007 at 07:59:05PM +0100, KolbjXrn StuestXl wrote:

argh - that patch does not work. I just applied it and did a complete
rebuild for de only[1].
First problem is "find: -wholename: unknown expression primary", obviously the -wholename parameter does not exist on the OS X version
of find?!

Well does or does it not exist on the Mac OS X platform?

the parameter does not show up in man find and a dirty try showed:

find -wholename find: illegal option -- w
find: illegal option -- h
find: illegal option -- o
find: illegal option -- l
find: illegal option -- e
find: illegal option -- n
find: illegal option -- a
find: illegal option -- m
find: illegal option -- e
usage: find [-H | -L | -P] [-EXdsx] [-f file] [file ...] [expression]

I guess that means, that this option does not exist on darwin / OS X

Greetings, lexA

As a result (?) all(!) images are missing in the html version. I guess we need to review this urgently.

As I tried with my built, don't do it for one language only. All translations are using English based images. As Sven stated, it makes also sense to install English as a fallback language.

well I do now this and tried it with ALL_LINGUAS="en de" too of course. In addition I replaced the -wholename by -name. The results where not very promising anyways. de images where still missing.

It doesn't work for me either.

But of more importance to me:

I get no error messages about the missing image files. I had to look through
the html files to find them.

Why not put all the 'en' images in an 'en' folder leaving the common images in
the root in each folder? It would then be necessary to copy only the common
images + lang specific images (folders). Perhaps there is other problems using
this solution?

Hm.. no - see the solution above.

uh, which solution?!

Greetings, lexA

Greetings,

Moin Axel,

On Fri, Jan 26, 2007 at 10:31:56PM +0100, Axel Wernicke wrote:

Am 26.01.2007 um 21:39 schrieb Roman Joost:

On Fri, Jan 26, 2007 at 07:59:05PM +0100, KolbjXrn StuestXl wrote:

argh - that patch does not work. I just applied it and did a complete
rebuild for de only[1].
First problem is "find: -wholename: unknown expression primary", obviously the -wholename parameter does not exist on the OS X version
of find?!

Well does or does it not exist on the Mac OS X platform?

the parameter does not show up in man find and a dirty try showed: [...]

I guess that means, that this option does not exist on darwin / OS X

What version of find do you use on OS X? Either we need to rewrite the way, the target is trying to find the images or - maybe - you can update your 'find'.

As a result (?) all(!) images are missing in the html version. I guess we need to review this urgently.

As I tried with my built, don't do it for one language only. All translations are using English based images. As Sven stated, it makes also sense to install English as a fallback language.

well I do know this and tried it with ALL_LINGUAS="en de" too of course. In addition I replaced the -wholename by -name. The results where not very promising anyways. de images where still missing.

Heh - of course it won't work. The find command doesn't perform the necessary operation, which is: finding the necessary files.

[...]
Perhaps there is other
problems using
this solution?

Hm.. no - see the solution above.

uh, which solution?!

Creating HTML for two languages: English as a fallback and German, for example.

Greetings,

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1

Hi Roman,

Am 27.01.2007 um 08:48 schrieb Roman Joost:

Moin Axel,

On Fri, Jan 26, 2007 at 10:31:56PM +0100, Axel Wernicke wrote:

Am 26.01.2007 um 21:39 schrieb Roman Joost:

[...]

I guess that means, that this option does not exist on darwin / OS X

What version of find do you use on OS X? Either we need to rewrite the way, the target is trying to find the images or - maybe - you can update
your 'find'.

well, besides I'm using the most recent OS X version 10.4.8 I doubt that find changes much trough versions. It a very old command and unlikely to change often. May be that is just one of the examples where different *nix platforms simply are that - different. Since the manual belongs to GIMP and GIMP is running on dozens of different OS's, we might leave out the more exotic parameters anyways?! What exactly does the -wholename do? Is there not a more portable way to do it?

[...]

Hm.. no - see the solution above.

uh, which solution?!

Creating HTML for two languages: English as a fallback and German, for example.

[x] agreed

Greetings, lexA

Greetings,

On Sat, Jan 27, 2007 at 11:35:38AM +0300, Peter Volkov (pva) wrote:

Btw. a good place to paste a new patch would be bugzilla.

Ok. It's not clear what does website component means either this is default for all languages or does it affects www site only, but in any case, here it is:
http://bugzilla.gnome.org/401263

Thanks - I moved it to 'General' component. I wonder if we really need something like a 'technical' component.

BTW. I found that version 0.12 for gimp-help exist in bugzilla but I have not found this release on download page. Could anybody clarify on that? I'm new to list. Is there supposed to be any announce on this list?

No - there isn't such a version yet. I just added it as a future version. Sorry for the confusion - i'll fix that.

Greetings,

----- Original Message ---

----- Original Message ---

Hi there,

I'm sorry, but I cant apply the patch you sent. Which was the version you patched in terms of svn revision? Or even better, can please somebody send me a patched Makefile.am ?

Thanks a lot.

lexA

Am 27.01.2007 um 09:35 schrieb Peter Volkov (pva):

Hello.

Thank you all for feedback. Roman, Sven I've fixed patch. The following
modifications were done:

* Always install pictures in listed in IMAGE_DIRS (images for en) * find does not use -wholename option. Axel, I hope grep exist on darwin / Mac OS (?) Could you, please, test this patch? * As Martin (in our bugzilla) suggested process of copying should abort
on error

With this changes I'd like to point your attention at two things: 1. Now it's possible to create "en" directory for images which are required only for English language. Build process will not install this
images if "en" it not in ALL_LINGUAS 2. If you ever create new base images subdirectory (in other words subdirectory which is *not* $lang subdirectory) it's necessary to list that directory in IMAGE_DIRS inside Makefile.am. This change I've documented in README (another patch in attachment).

Kolbj?rn, if this patch does not work for you, please, give me a little
bit more details. At least I need to know what do you have in ALL_LINGUAS.

Btw. a good place to paste a new patch would be bugzilla.

Ok. It's not clear what does website component means either this is default for all languages or does it affects www site only, but in any case, here it is:
http://bugzilla.gnome.org/401263

BTW. I found that version 0.12 for gimp-help exist in bugzilla but I have not found this release on download page. Could anybody clarify on that? I'm new to list. Is there supposed to be any announce on this list?

Peter.

Hi Axel,

On Sun, Jan 28, 2007 at 12:16:14PM +0100, Axel Wernicke wrote:

I'm sorry, but I cant apply the patch you sent. Which was the version you patched in terms of svn revision? Or even better, can please somebody send me a patched Makefile.am ?

If you want to try the Patch Peter sent, download it from the bug registered in bugzilla:

http://bugzilla.gnome.org/show_bug.cgi?id=401263

If you want to revert local changes on your sandbox, use:

svn revert Makefile.am

for example.

Greetings,

On Sun, Jan 28, 2007 at 12:16:14PM +0100, Axel Wernicke wrote:

I'm sorry, but I cant apply the patch you sent. Which was the version you patched in terms of svn revision? Or even better, can please somebody send me a patched Makefile.am ?

Just tried the patch and it works for me well.

Axel you want to use Revision 1583 of the Makefile.am. Sorry - was a bit to fast replying to your last mail ;)

Greetings,

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1

Hi list,

1. the patch can be applied - if you try to patch Revision 1583 -> it worked for me

2. the language dependent building for images works with this patch. I've no obligations against putting it into the svn by now.

Greetings, lexA

Am 28.01.2007 um 14:07 schrieb Roman Joost:

On Sun, Jan 28, 2007 at 12:16:14PM +0100, Axel Wernicke wrote:

I'm sorry, but I cant apply the patch you sent. Which was the version you
patched in terms of svn revision? Or even better, can please somebody send me a
patched Makefile.am ?

Just tried the patch and it works for me well.

Axel you want to use Revision 1583 of the Makefile.am. Sorry - was a bit
to fast replying to your last mail ;)

Greetings,

Hi
The make ALL_LINGUAS="no" command now works fine, creating only the common ('en') images + the 'no' folders. But there is a minor bug somewhere: It looks like the program is trying to create the html folder twice:

*** Creating directories *** Creating base image dirrectories.
mkdir: cannot create directory `html/images/.': File exists .
This appears even if I start the make from scratch without any of the folders normally created by the program itself. Kolbjoern

----- Original Message ---

On Tue, Jan 30, 2007 at 10:47:02PM +0100, KolbjXrn StuestXl wrote:

Hi
The make ALL_LINGUAS="no" command now works fine, creating only the common ('en') images + the 'no' folders. But there is a minor bug somewhere: It looks like the program is trying to create the html folder twice:

*** Creating directories *** Creating base image dirrectories.
mkdir: cannot create directory `html/images/.': File exists .
This appears even if I start the make from scratch without any of the folders normally created by the program itself.

I'd recommend filing a bug on bugzilla. I'll won't have the time to fix this minor thing this week.

Thanks,